1421097 - Require Rust 1.22

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Ralph Giles (:rillian)]

We can start requiring Rust 1.22 to build Firefox 59 starting 2017 December 7.

Comment 1

[Mike Hommey [:glandium]]

Not until we at least build with 1.22 on Windows.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

We'll need Rust 1.22 for the webrender update which contains servo/webrender#2128. No pressure or anything but we would really like to get that in before the all-hands :)

The specific problem is that 1.21 fails to properly handle [patch] replacements where we replace a crates.io crate with one from a git repo. Try push showing the failures is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=564675d02666501b448090a8c9076f24edf3f94c

Comment 3

[Nicholas Nethercote [inactive]]

My code in bug 1423840 currently relies on Option<> working with '?', which was added in 1.22. I could modify it to not use that feature without much difficulty, but it would be nice if I didn't have to :)

Comment 4

[Nicholas Nethercote [inactive]]

FWIW, https://treeherder.mozilla.org/#/jobs?repo=try&revision=0705f935b4c92a819400c62e69a84ead93be8b85 is a try push that contains code using 1.22 features. It's failing to build on Windows and Linux "Bb" jobs.

Comment 5

[Ralph Giles (:rillian)]

This bug is currently blocked, so we're going to miss the scheduled bump date.

We're waiting on a rust 1.23.0-beta.2 release after rust-lang/rust#46516 lands, which I expect to fix hsivonen/encoding_rs#26. Hopefully that will be soon, but not before the All Hands. If things are on fire, I can do a custom build, but I'd prefer to wait for the upstream release.

The "Bb" or "baseline toolchain" builds are in fact there to block code that depends on 1.22 features until this bug can land.

Comment 6

[Nicholas Nethercote [inactive]]

> The "Bb" or "baseline toolchain" builds are in fact there to block code that
> depends on 1.22 features until this bug can land.

In that case, they are working well! :)

Comment 7

[Ralph Giles (:rillian)]

Attachment: Bug 1421097 - Require at least Rust 1.22.1.

Bump the minimum required Rust version now that 1.22.1
has been in stable release for more than two weeks.

Version 1.22.0 works fine everwhere but macOS 10.13,
but 1.22.1 was released the same day, so it's no harder
to upgrade to.

Also update the base-toolchain builds to ensure we
continue to build with this version.

Review commit: https://reviewboard.mozilla.org/r/206538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206538/

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8935644 [details]
Bug 1421097 - Require at least Rust 1.22.1.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206538/diff/1-2/

Comment 9

[(not currently active) Ted Mielczarek]

Comment on attachment 8935644 [details]
Bug 1421097 - Require at least Rust 1.22.1.

https://reviewboard.mozilla.org/r/206538/#review212494

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27fdcafdb961
Require at least Rust 1.22.1. r=ted

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/27fdcafdb961

Comment 12

[Boris Zbarsky [:bzbarsky]]

This didn't update "mach bootstrap", so not mach bootstrap claims rust is new enough but the actual build fails...

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Bug 1424439 is updating that

Comment 14

[Sylvestre Ledru [:Sylvestre]]

I reported bug 1424489 to avoid this situation from happening in the future.