1411521 - [PWA] javascript:void(0) is opened as external page on page added to home screen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[krzysdz]

Attachment: Screenshot_2017-10-25-09-53-12-904_org.mozilla.fennec_aurora.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171024220325

Steps to reproduce:

I've added https://anulowano.pl/ to home screen and I've clicked "Menu" button (it's visible only on small screens). It is an "a" element with href="javascript:void(0)"


Actual results:

A tab with url "javascript:void(0)" has opened (like on attached screenshot)


Expected results:

On Chrome and Firefox Nightly in normal browser menu just opens, without a new empty tab.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Please help prioritize this

Comment 2

[krzysdz]

Adding something like:

if (urlStr.startsWith("javascript:")){
    return false;
}

in mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java in onLoadUri (before `if ("http"...` - about line 324) helps, but I'm not sure if it is a proper way to solve this problem (I was wondering if return true would also work, but it breaks things like `<a href="javascript:alert('TEST')">test</a>`, while returning false makes everything work good - no new tab and alert works).
It would be great if you could check it.

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Hi snorp
Do you think we should handle this in GeckoView?

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Dylan, looks like this is another edge case to handle.

Comment 5

[Dylan Roeh (:droeh) (he/him)]

Attachment: Handle javascript: URIs

Yeah, javascript: uris will currently get bounced to custom tabs because they fail the scope check. This patch just adds a special case for them in onLoadUri().

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4851b138288
Handle javascript: URIs properly in PWAs. r=snorp

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f4851b138288

Comment 8

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 59 (2018-01-08).
Device: Prestigio Grace X5 (Android 4.4.2)