1411545 - streamClosed: this statement may fall through

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

/root/firefox-gcc-last/js/src/wasm/WasmJS.cpp: In member function 'virtual void CompileStreamTask::streamClosed(JS::StreamConsumer::CloseReason)':
 /root/firefox-gcc-last/js/src/wasm/WasmJS.cpp:2315:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
              }
              ^

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1411545 - streamClosed: Fix the implicit-fallthrough warning

Review commit: https://reviewboard.mozilla.org/r/192878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192878/

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8921840 [details]
Bug 1411545 - streamClosed: Fix the implicit-fallthrough warning

https://reviewboard.mozilla.org/r/192878/#review198148

::: js/src/wasm/WasmJS.cpp:2316
(Diff revision 1)
>                  setClosedAndDestroyAfterHelperThreadStarted();
>                  return;
>                case Closed:
>                  MOZ_CRASH("streamClosed() in Closed state");
>              }
> +            break;

Ah, didn't know about this warning.  Thanks for the patch!  For symmetry, could you add a 'break' below at the end of the Error case too?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8921840 [details]
Bug 1411545 - streamClosed: Fix the implicit-fallthrough warning

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192878/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7bd525a3831
streamClosed: Fix the implicit-fallthrough warning r=luke

Comment 5

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/d7bd525a3831