1411577 - Unbookmarking a Pocket recommendation wrongly changes its status from Bookmarked to Visited instead of Trending

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: pocket recommandation status incorrectly changed from trending.gif

[Affected versions]:
- Firefox 58.0a1 Build ID 20171024220325

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- "browser.search.region" is set to "US" in about:config

[Steps to reproduce]:
1. Open the browser and open a new tab.
2. Bookmark a Pocket recommendation from the context menu.
3. Observe the card's status.

[Expected results]:
- Card's status is "Trending".

[Actual results]:
- Card's status is "Bookmarked".

[Additional notes]:
- If you remove the bookmark from the context menu, the card's status changes to "Visited". Restarting the browser resets the card's status back to Trending.
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

This is an intended change from https://github.com/mozilla/activity-stream/pull/3675 in fixing bug 1404261.

Comment 2

[Ciprian Muresan [:cmuresan], Ecosystem QA]

@Mardak, could you please explain how these transitions will work from now on?

Because now we have the following:
If you bookmark a Pocket recommendation it changes from Trending to Bookmarked. 
If you remove the bookmark it changes from Bookmarked to Visited. (at this point I haven't visited the page so saying it was Visited doesn't seem right)
If you restart the browser the recommendation changes from Visited to Trending. (if the above is expected, then wouldn't it be expected for the status to not change after a restart?)

Is this the way they are supposed to be?

Comment 3

[Ed Lee :Mardak]

Waiting for design feedback

Comment 4

[Mike Taylor [:miketaylr]]

I'm gonna set this to fix-optional for 58, because it doesn't sound like there's consensus on what the right behavior should be.

Comment 5

[Ed Lee :Mardak]

Still waiting on design feedback in the issue. Design originally said bookmarking a story should make it show "Bookmarked" and that removing a bookmark from a "Bookmarked" card should make it "Visited" (at least in the context of Highlights). So the design feedback needed is specifically for removing a bookmark for a "Bookmarked" story card.

Comment 6

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in nightly; if it seems low risk enough please feel free to request uplift to 65 beta.