1404261 - Bookmarked status for Highlights is only shown after you click the context menu a second time

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: bookmark state for highlights not displayed instantly.gif

[Affected versions]:
- Firefox 58.0a1 Build ID 20170928220658

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have enough history so that Highlights are displayed.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites and open a New Tab.
2. Click the "..." for one of the Highlights.
3. Click the "Bookmark" option and observe the bottom left corner of the card.

[Expected results]:
- The status of the card is changed to "Bookmarked"

[Actual results]:
- The status of the card remains unchanged.

[Regression window]:
Last good revision: d7ccda988869be632fb6b3345d3efba111db7f7d
First bad revision: 3b514f20525296a9b6a623ba680fb027bc9e6cae
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d7ccda988869be632fb6b3345d3efba111db7f7d&tochange=3b514f20525296a9b6a623ba680fb027bc9e6cae

[Notes]:
- Dismissing a different Highlight will refresh the affected card and it will correctly show its status.
- The status is correctly displayed after the page is refreshed.
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3623 to be uplifted via bug 1405539.

Comment 2

[Ed Lee :Mardak]

The fix from https://github.com/mozilla/activity-stream/pull/3623 has been backed out

Comment 3

[Ed Lee :Mardak]

Try again fixed by https://github.com/mozilla/activity-stream/pull/3675 to be uplifted via bug 1407657.

Comment 4

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that this issue is no longer reproducible on Win 10 x64, Mac 10.12.6 & Arch Linux x64 with Nightly 58 (Build ID  20171015220106).