1411591 - Make the accessibility visual indicator off by default in 57

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I'd like to track this as a 57 blocker. The sooner we have a patch ready for uplift the better. RC week begins Nov6th.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1411591 patch

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8922808 [details] [diff] [review]
1411591 patch

Review of attachment 8922808 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c34e87883dcd
making accessibility indicator off by default. r=davidb

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c34e87883dcd

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8922808 [details] [diff] [review]
1411591 patch

Approval Request Comment
[Feature/Bug causing the regression]: Not a regression. Decision has been made to pref off the accessibility indicator by default in Firefox 57 and do a Shield Study to better understand the effect of the indicator on Firefox users (whether it is positive or confusing).
[User impact if declined]: From telemetry it looks like 7% of users will see the indicator. We would not want to confuse them so we are leaning towards a Shield study first.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just a pref change to not show accessibility indicator. It is already covered by tests.
[String changes made/needed]: None

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8922808 [details] [diff] [review]
1411591 patch

Must fix, Beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6085ed28ca89

Comment 9

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified fixed in 57.b13 & Nightly 58.0a1 (id: 20171031235118).
The Accessibility icon does not appear anymore.