1411602 - controlCenter_about does not show the control center

Status: VERIFIED FIXED

(Testing :: mozscreenshots, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

Bug 1393802 removed the identity block from about:home and thus we can't open the control center anymore on that page. While it's nice to have a screenshot test of about:home we should probably do that in a dedicated configuration and switch to a different page for testing the control center on about pages.

See https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=d9b405d82cffb07343a5f2fd941e029298c7f6c4&newProject=mozilla-central&newRev=04b6be50a2526c7a26a63715f441c47e1aa1f9be&filter=about

Comment 1

[rndmustafa]

Attachment: Bug 1411602 - controlCenter_about does not show the control center.

Review commit: https://reviewboard.mozilla.org/r/196396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196396/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8925143 [details]
Bug 1411602 - controlCenter_about does not show the control center.

https://reviewboard.mozilla.org/r/196396/#review201600

Just happened to see this go by. Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e0723d7f6ed
controlCenter_about does not show the control center. r=MattN

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5e0723d7f6ed

Comment 5

[Johann Hofmann [:johannh]]

This worked, great job!

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=66f496680fae6e7d8f02bc17ff58b9234ee07c70&newProject=mozilla-central&newRev=52b2b0d65a904292c5646494183ede51ab842349&filter=_about

FYI, we've had a lot of mysterious intermittent 4px and 8px inconsistencies on controlCenter_about configurations that this patch also got rid of. So thanks for that as well!