Closed Bug 1393802 Opened 6 years ago Closed 6 years ago
URL bar for about:home should have the same styling as about:newtab
59 bytes, text/x-review-board-request
The URL bar styling was updated for about:newtab and the same design needs to be applied to about:home. (See reference bug 1390359)
Assignee: nobody → dao+bmo
Priority: P4 → P1
Status: NEW → ASSIGNED
Iteration: --- → 57.2 - Aug 29
QA Contact: ovidiu.boca
I'm on PTO and won't be able to review this until Friday Sept. 1 or the week after. Please pick a different reviewer if you need it reviewed before then.
Attachment #8901265 - Flags: review?(gijskruitbosch+bugs) → review?(florian)
If I may add something to the topic, I noticed that "search" icon in about:newtab URL bar added in bug 1390359 has opposite design to the "search" icon in search bar above site tiles (activity-stream disabled). about:home is using the same search bar icon design as about:newtab. To me it looks a bit inconsistent, but to be fair there are more search bars across browser, and as far as I can see only about:home and about:newtab main search bars are using different icon. about:home will be basically first time where both designs will be in use by default, so perhaps it's worth to consider some alignments (if it was not intentional). See screenshot: https://s2.postimg.org/k2nzjhd3d/icons.png
Comment on attachment 8901265 [details] Bug 1393802 - Make about:home's identity block consistent with about:newtab's. https://reviewboard.mozilla.org/r/172720/#review179482 Looks good to me! I'm glad this removes the initIdentityBlock hack I had to introduce in bug 1372518 (and even happier that I'm seeing this patch before filing a bug on this 'Nightly' block sometimes flickering again in the current nightly, probably regressed by bug 1054740).
Attachment #8901265 - Flags: review?(florian) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s e6c989d06cc5 -d c178d9e31307: rebasing 416822:e6c989d06cc5 "Bug 1393802 - Make about:home's identity block consistent with about:newtab's. r=florian" (tip) merging browser/base/content/browser.js merging browser/base/content/test/general/browser_bookmark_popup.js merging browser/base/content/test/urlbar/browser_page_action_menu.js warning: conflicts while merging browser/base/content/test/general/browser_bookmark_popup.js! (edit, then use 'hg resolve --mark') warning: conflicts while merging browser/base/content/test/urlbar/browser_page_action_menu.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/434a7900c855 Make about:home's identity block consistent with about:newtab's. r=florian
I have reproduced this Bug on Nightly 57.0a1 (2017-08-25) on Windows 10, 64 bit! The bug's fix is now verified on latest Nightly 57.0a1 Build ID : 20170831100258 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170830]
6 years ago
Depends on: 1395961
You need to log in before you can comment on or make changes to this bug.