1393802 - URL bar for about:home should have the same styling as about:newtab

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Aaron Benson]

The URL bar styling was updated for about:newtab and the same design needs to be applied to about:home. (See reference bug 1390359)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1393802 - Make about:home's identity block consistent with about:newtab's.

Review commit: https://reviewboard.mozilla.org/r/172720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172720/

Comment 2

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3feaf831dc2520c8a6ef542a0823ea67efb6663a

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8901265 [details]
Bug 1393802 - Make about:home's identity block consistent with about:newtab's.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172720/diff/1-2/

Comment 4

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0f28cc696035889b3e78acb348d6adcbad5cf9b

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8901265 [details]
Bug 1393802 - Make about:home's identity block consistent with about:newtab's.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172720/diff/2-3/

Comment 6

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fd21ec111c1fb25e461338e84a7adbf64b82b42

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8901265 [details]
Bug 1393802 - Make about:home's identity block consistent with about:newtab's.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172720/diff/3-4/

Comment 8

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=677d8e1bf67088739455f0c1b2dd5b8c03bb390f

Comment 9

[:Gijs (he/him)]

I'm on PTO and won't be able to review this until Friday Sept. 1 or the week after. Please pick a different reviewer if you need it reviewed before then.

Comment 10

[Edo Karabas]

If I may add something to the topic, I noticed that "search" icon in about:newtab URL bar added in bug 1390359 has opposite design to the "search" icon in search bar above site tiles (activity-stream disabled). 
about:home is using the same search bar icon design as about:newtab.
To me it looks a bit inconsistent, but to be fair there are more search bars across browser, and as far as I can see only about:home and about:newtab main search bars are using different icon. 
about:home will be basically first time where both designs will be in use by default, so perhaps it's worth to consider some alignments (if it was not intentional).
See screenshot: https://s2.postimg.org/k2nzjhd3d/icons.png

Comment 11

[Florian Quèze [:florian]]

Comment on attachment 8901265 [details]
Bug 1393802 - Make about:home's identity block consistent with about:newtab's.

https://reviewboard.mozilla.org/r/172720/#review179482

Looks good to me! I'm glad this removes the initIdentityBlock hack I had to introduce in bug 1372518 (and even happier that I'm seeing this patch before filing a bug on this 'Nightly' block sometimes flickering again in the current nightly, probably regressed by bug 1054740).

Comment 12

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s e6c989d06cc5 -d c178d9e31307: rebasing 416822:e6c989d06cc5 "Bug 1393802 - Make about:home's identity block consistent with about:newtab's. r=florian" (tip)
merging browser/base/content/browser.js
merging browser/base/content/test/general/browser_bookmark_popup.js
merging browser/base/content/test/urlbar/browser_page_action_menu.js
warning: conflicts while merging browser/base/content/test/general/browser_bookmark_popup.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/base/content/test/urlbar/browser_page_action_menu.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 8901265 [details]
Bug 1393802 - Make about:home's identity block consistent with about:newtab's.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172720/diff/4-5/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/434a7900c855
Make about:home's identity block consistent with about:newtab's. r=florian

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/434a7900c855

Comment 16

[Saddam Hossain]

I have reproduced this Bug on Nightly 57.0a1 (2017-08-25) on Windows 10, 64 bit!

The bug's fix is now verified on latest  Nightly 57.0a1

Build ID    :	20170831100258
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0