Closed Bug 1411714 Opened 3 years ago Closed 3 years ago

Incorrect Sync onboarding flow

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: eoger, Assigned: eoger)

References

Details

Attachments

(1 file)

STR (1):
- Open the UI Tour page in about:newtab
- Go to the Sync section

Expected:
The copy should be "Connect to Sync" or something that doesn't implicate that you have/don't have an account.

Actual:
"Create a Firefox Account to continue to Firefox Sync"

STR (2):
- Start at (1)
- Enter a Sync email with an existing account and click the Next button

Expected:
Should get redirected directly to a sign-in form on FxA since I possess an account.

Actual:
Redirected to about:accounts with a "Get Started" button, then when I press it I end up in a sign-up form with the email pre-filled.

STR (3):
- Start at (1)
- Enter a Sync email not registered with an account and click the Next button

Expected:
Should get redirected directly to a sign-up form on FxA since I don't possess an account.

Actual:
Redirected to about:accounts with a "Get Started" button, then when I press it I end up in a sign-up form with the email pre-filled.
Comment on attachment 8922077 [details]
Bug 1411714 - Handle action=email in about:accounts.

https://reviewboard.mozilla.org/r/193066/#review198328

Looks good to me.
Attachment #8922077 - Flags: review?(tchiovoloni) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e7a89e29f29
Handle action=email in about:accounts. r=tcsc
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/6e7a89e29f29
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Component: Firefox Sync → Sync
Product: Tracking → Firefox
Version: --- → unspecified
Comment on attachment 8922077 [details]
Bug 1411714 - Handle action=email in about:accounts.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1392959
[User impact if declined]: This might result in a very confusing/frustrating flow for users who just upgraded to Firefox and are interested in Sync.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No need for QE, but you can follow the instructions on comment 1.
[List of other uplifts needed for the feature/fix]: -
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: This change is manually and automatically tested.
[String changes made/needed]: None
Attachment #8922077 - Flags: approval-mozilla-beta?
> This might result in a very confusing/frustrating flow for users who just upgraded to Firefox and are interested in Sync.

Alex (our PM) is PTO for the rest of this week, but I feel qualified to channel him a little here and replace the "might" in the above with "will definitely".  The part of most concern is this:

> STR (2):
> [...]
> Redirected to about:accounts with a "Get Started" button, then when I press it I end
> up in a sign-up form with the email pre-filled.

Users who attempt to set up sync during the onboarding flow will:

* Enter their email address in the "sync" section of onboarding, and click "next"
* See a completely useless "Welcome to Sync!" page and have to click "Get Started" despite the fact they already started
* Be taken to the Firefox Accounts signup form to continue setting up sync

That second screen serves no purpose and can only confuse users and cause them to drop out of the sync setup flow.  It might even cause them to think they're successfully syncing (after all, they filled out the form!) when they're not.

If this flow were tucked away in preferences somewhere I don't think we'd worry about requesting uplift here.  But this is right up front in a new user's first experience of the product, and really doesn't help set them up to succeed.
> That second screen serves no purpose and can only confuse users and cause them to drop out of the sync setup flow.

That said, I also want to be clear that the sync setup flow still works in this case; it's just jarring and confusing that we display an extra screen for no reason in an otherwise very slick onboarding flow.
Comment on attachment 8922077 [details]
Bug 1411714 - Handle action=email in about:accounts.

Another one that is onboarding related, Beta57+
Attachment #8922077 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Target Milestone: --- → Firefox 58
(In reply to Edouard Oger [:eoger] from comment #5)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No need for QE, but
> you can follow the instructions on comment 1.

Setting qe-verify- based on Edouard's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.