Closed
Bug 1411881
Opened 7 years ago
Closed 7 years ago
Don't let UnmarkFrameForDisplay clobber entries added as MarkFrameForDisplayAsVisible
Categories
(Core :: Web Painting, enhancement)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
|
4.18 KB,
patch
|
ethlin
:
review+
|
Details | Diff | Splinter Review |
When we exit a subdocument, we clear all frames from mFramesMarkedForDisplay and clear their flags, but this can end up clearing the mark frame for display if visible flags set by the root document.
This causes flickering on this testcase: https://goo.gl/pNuvJM
Simplest thing to do seems to completely separate the two types and keep have their own arrays.
Attachment #8922233 -
Flags: review?(ethlin)
|
||
Updated•7 years ago
|
Attachment #8922233 -
Flags: review?(ethlin) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cadcd4af281
Use separate lists for MarkFrameForDisplay and MarkFrameForDisplayIfVisible to avoid them clobbering each other when we leave a PresShell. r=ethanlin
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•