1411988 - IE Maze solver speed regressed significantly over the last 2 weeks

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Pascal Chevrel:pascalc]

Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 ID:20171025230440

Go to https://testdrive-archive.azurewebsites.net/Performance/MazeSolver/Default.html and click on start (default 30x30 maze)

Firefox 56 on my machine takes 14s, the last nightly build with a fresh profile takes 33s.

I tested with mozregression and the last build giving ~14s was the one on 2017-10-17 then we jumped to 22s

Last good revision: 1498abcee79d232125fb44846849160ec3c1fa51
First bad revision: 940a0c98e46c363d97e9cc8ef448faec9ff725f2
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1498abcee79d232125fb44846849160ec3c1fa51&tochange=940a0c98e46c363d97e9cc8ef448faec9ff725f2

Two bugs were listed as the cause: bug 1407815 and bug 1406727

Then 2 days ago there was another regression on this test that made us jump from 22s to 33s and for this one mozregression gave me this:

Last good revision: 71a01e882f44c3143b9b2dd777f988f58e7af862
First bad revision: 8990a530c1eaaec234bfb37b5860cde8a4c0bec7
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=71a01e882f44c3143b9b2dd777f988f58e7af862&tochange=8990a530c1eaaec234bfb37b5860cde8a4c0bec7

The only patch in this regression window is bug 1405146 which was also blocking bug 1407815 which caused the first perf regression.


I don't know if we care about this css performance test or not, Matt could you have a look since the regression seems to have been caused by the patches for retained display list? Thanks

Comment 1

[Mike Taylor [:miketaylr]]

Yeah, this is pretty bad on my Mac as well (13seconds in 57 -> 34seconds 58).

Comment 2

[Mike Taylor [:miketaylr]]

Oops, sorry. Matt, can you take a look?

Comment 3

[Mike Taylor [:miketaylr]]

Jet, any thoughts on this layout regression?

Comment 4

[Matt Woodrow (:mattwoodrow)]

These changes should only affect Nightly/Beta, and are going to be backed out soon.

Comment 5

[Mike Taylor [:miketaylr]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #4)
> These changes should only affect Nightly/Beta, and are going to be backed
> out soon.

Cool, thanks.

Comment 6

[Gerry Chang [:gchang]]

Can we check if this issue still happened in Beta58 (this pref is off by default in beta)?

Comment 7

[Pascal Chevrel:pascalc]

(In reply to Gerry Chang [:gchang] from comment #6)
> Can we check if this issue still happened in Beta58 (this pref is off by
> default in beta)?

Beta 5 of 58 takes 14s

Comment 8

[Astley Chen (inactive)]

59.0a1 (2017-11-26) (64-bit) took 14s too.

Comment 9

[Astley Chen (inactive)]

Fixed in bug 1406727.