Closed
Bug 1412074
Opened 8 years ago
Closed 8 years ago
Test JSONView.encoding in browser_jsonview_encoding.js
Categories
(DevTools :: JSON Viewer, defect)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: Oriol, Assigned: Oriol)
References
Details
Attachments
(1 file)
In bug 1396286 I didn't test the encoding because it's not displayed to the user (bug 1408652). But since bug 1388335, evalInContent can be used to test JSONView.encoding
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8922461 [details]
Bug 1412074 - Test JSONView.encoding in browser_jsonview_encoding.js
https://reviewboard.mozilla.org/r/193536/#review200026
Seems reasonable, thanks for the patch Oriol!
R+ assuming try is green
Honza
Attachment #8922461 -
Flags: review?(odvarko) → review+
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e318d13beafc
Test JSONView.encoding in browser_jsonview_encoding.js r=Honza
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•