Closed
Bug 1412125
Opened 7 years ago
Closed 7 years ago
Re-fix mode lines in dom/
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(3 files)
There have been "a few" new files added in the last two years since I did bug 1152551, so I think it is time to do this again. (As before, I have excluded dom/media.) Of course, the patch is much smaller this time (it was 1.2MB last time).
Assignee | ||
Comment 1•7 years ago
|
||
This is the version of the script that I used to generate this patch. The canonical repo for this is: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py/
In addition to making sure that the mode lines and MPL match those in the Coding Style guide, it also performs a rough analysis to make sure that the file is actually 2 space indented and not 4 space indented. Of course, this is somewhat ambiguous in general, so there's a conservative heuristic about the ratio between the two. If the script decides the file might be 4 space indented, it produces an error and I manually examine the file to decide if it is actually 2 space indented. If it is, I add it to a whitelist in the script (indentWhiteList), otherwise I add it to a blacklist (fileBlackList). This is mostly a problem for header files.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8922550 [details]
Bug 1412125, part 1 - Manually add mode lines and MPL to files that were missing them entirely.
https://reviewboard.mozilla.org/r/193628/#review198768
Attachment #8922550 -
Flags: review?(kyle) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8922551 [details]
Bug 1412125, part 2 - Fix dom/ mode lines.
https://reviewboard.mozilla.org/r/193630/#review198770
Attachment #8922551 -
Flags: review?(kyle) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e2976d8a5e1
part 1 - Manually add mode lines and MPL to files that were missing them entirely. r=qdot
https://hg.mozilla.org/integration/autoland/rev/cb123c84818a
part 2 - Fix dom/ mode lines. r=qdot
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e2976d8a5e1
https://hg.mozilla.org/mozilla-central/rev/cb123c84818a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•