Re-fix mode lines in dom/

RESOLVED FIXED in Firefox 58

Status

()

enhancement
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(3 attachments)

There have been "a few" new files added in the last two years since I did bug 1152551, so I think it is time to do this again. (As before, I have excluded dom/media.) Of course, the patch is much smaller this time (it was 1.2MB last time).
Posted file Modeline script
This is the version of the script that I used to generate this patch. The canonical repo for this is: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py/

In addition to making sure that the mode lines and MPL match those in the Coding Style guide, it also performs a rough analysis to make sure that the file is actually 2 space indented and not 4 space indented. Of course, this is somewhat ambiguous in general, so there's a conservative heuristic about the ratio between the two. If the script decides the file might be 4 space indented, it produces an error and I manually examine the file to decide if it is actually 2 space indented. If it is, I add it to a whitelist in the script (indentWhiteList), otherwise I add it to a blacklist (fileBlackList). This is mostly a problem for header files.
Comment on attachment 8922550 [details]
Bug 1412125, part 1 - Manually add mode lines and MPL to files that were missing them entirely.

https://reviewboard.mozilla.org/r/193628/#review198768
Attachment #8922550 - Flags: review?(kyle) → review+
Comment on attachment 8922551 [details]
Bug 1412125, part 2 - Fix dom/ mode lines.

https://reviewboard.mozilla.org/r/193630/#review198770
Attachment #8922551 - Flags: review?(kyle) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e2976d8a5e1
part 1 - Manually add mode lines and MPL to files that were missing them entirely. r=qdot
https://hg.mozilla.org/integration/autoland/rev/cb123c84818a
part 2 - Fix dom/ mode lines. r=qdot
https://hg.mozilla.org/mozilla-central/rev/8e2976d8a5e1
https://hg.mozilla.org/mozilla-central/rev/cb123c84818a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.