1412218 - Add telemetry probe for how many users with legacy cookie files

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement, P2)

Description

[Junior [inactive]]

According to bug b870460 comment 66, some io are redundant for most of the users.

Comment 1

[Junior [inactive]]

Quick note:
cookies.txt disappears in 2007
Scheme 1->2: 2010
Scheme 2->3: 2010
Scheme 3->4: 2012
Scheme 4->5: 2015
Scheme 5->6: 2015
Scheme 6->7: 2017
Scheme 7->8: 2017

If we're going to land it in 58, we can see the probe in central next min-January.

Comment 2

[Junior [inactive]]

> Scheme 1->2: 2010
> Scheme 2->3: 2010
> Scheme 3->4: 2012
> Scheme 4->5: 2015
> Scheme 5->6: 2015
> Scheme 6->7: 2017
> Scheme 7->8: 2017
Oops, all the numbers in the left should +1.
Correct time for Schema 1->2 is 2007.

Moreover, Schema 9 lands in 58 (Bug 1286858).
Hence it's expected that lots of upgrade in central 58 would in this telemetry

Comment 3

[Junior [inactive]]

Attachment: old_schema, v1

Comment 4

[Josh Matthews [:jdm]]

Comment on attachment 8924504 [details] [diff] [review]
old_schema, v1

Review of attachment 8924504 [details] [diff] [review]:
-----------------------------------------------------------------

This will need a data-review as well.

::: toolkit/components/telemetry/Histograms.json
@@ +4439,5 @@
>      "high": 3000,
>      "n_buckets": 10,
>      "description": "Time spent on SQLite read() (ms) *** No longer needed (bug 1156565). Delete histogram and accumulation code! ***"
>    },
> +

nit: remove this newline.

Comment 5

[Junior [inactive]]

Attachment: old_schema, v2

The telemetry is to see how many users need to migrate old cookie files. If it's not many, we could abandon some redundant IO

Comment 6

[François Marier [:francois]]

There is now a new process to follow for all new telemetry probes: https://wiki.mozilla.org/Firefox/Data_Collection#Step_1:_Submit_Request

Essentially, you need to copy and fill out the questionnaire and then attach it to the bug. I can review that file afterwards and I'll take care of completing Step 2.

Comment 7

[Junior [inactive]]

1) What questions will you answer with this data?
As the patch said, we would know how many users are with old schema version of the cookie database. Also the legacy cookies.txt

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
We had many redundant IO on cookie database in each startup for back-compatible.
No product and biz requirements.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
I didn't think of any other way to figure out.

4) Can current instrumentation answer these questions?
no

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.

Only one probes here
MOZ_SQLITE_COOKIES_OLD_SCHEMA
It's Category 1 “Technical data”
To collect how many users are with old schema version of the cookie database. Also the legacy cookies.txt

6) How long will this data be collected? Choose one of the following:
I want this data to be collected for 8 months initially (potentially renewable). (till next ESR)

7) What populations will you measure?
central mainly, good to know in nightly, beta

8) Please provide a general description of how you will analyze this data.
Simply see the numbers. Every user should only suffer from upgrading once for a installation.

9) Where do you intend to share the results of your analysis?
Only in bugzilla in Network:Cookies components

Comment 8

[François Marier [:francois]]

datareview+

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate? (see [here](https://github.com/mozilla/activity-stream/blob/master/docs/v2-system-addon/data_dictionary.md), [here](https://github.com/mozilla-mobile/focus/wiki/Install-and-event-tracking-with-the-Adjust-SDK), and [here](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/index.html) for examples).  Refer to the appendix for "documentation" if more detail about documentation standards is needed.

Yes.

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes: telemetry pref.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Not permanent.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

default-on, but pre-release only

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice? **If unsure: escalate to legal if:**

Yes: telemetry.

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No, telemetry email alerts are sufficient.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8110a775c106
Add telemetry probe for how many users with legacy cookie files. r=jdm, data-r=francois

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8110a775c106