Closed Bug 1412332 Opened 7 years ago Closed 6 years ago

Run Passwords Validator outside of aboutsync

Categories

(Firefox :: Sync, enhancement, P2)

Product:
Firefox
Component:
Sync
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

References

Details

Attachments

(1 file)

Bug 1412332 - Enable sync passwords validator for nightly and beta users.
59 bytes, text/x-review-board-request
markh
: review+
Details 
I helped a user on IRC today who had a large number of clientmissing password validation issues. We have very little insight into these, since we don't run password validation, and they don't always come with engine errors.

I'd be willing to do this after or as part of bug 1407067, it should be easy to do in that context.

It's worth noting that repair for password issues would be very easy compared to bookmarks, and the bookmark repair code was structured so that implementing repair for other engines is feasible.
Priority: -- → P2
I don't have a problem with this in general, but given bug 1377100 I'm not sure it will tell us anything we don't already know (ie, that quite a few users will have many client missing records). Given bug 1407067, it seems unlikely that we can rely on a repair feature in the addon to fix all users as I'm skeptical that addon will be rolled out to 100% of sync users any time soon.

So IMO, a higher priority should be to fix bug 1377100, possibly with some basic repair/reset process involved in that, after which the validation results are more likely to be meaningful.
See Also: → 1377100
Assignee: nobody → tchiovoloni
Comment on attachment 8947321 [details]
Bug 1412332 - Enable sync passwords validator for nightly and beta users.

https://reviewboard.mozilla.org/r/217034/#review222902

This LGTM, thanks. FWIW, note that I think clientmissing is going to be a problem whenever logins.json is lost (due to corruption etc), because Sync doesn't know all local logins have been lost, so doesn't do the full sync like it should. IMO we should work on fixing that issue before we consider making password repair roll out to release users (but this should still give us some insights into how often the problem occurs and should help us work out if that (currently mythical) fix does prevent most of these in the first place.
Attachment #8947321 - Flags: review?(markh) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 47e5c0eb1e9dfc494055a13baa8d8599ac38bb56 -d dbdd43825f46: rebasing 446468:47e5c0eb1e9d "Bug 1412332 - Enable sync passwords validator for nightly and beta users. r=markh" (tip)
merging services/sync/modules/service.js
warning: conflicts while merging services/sync/modules/service.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/288258ffdf21
Enable sync passwords validator for nightly and beta users. r=markh
https://hg.mozilla.org/mozilla-central/rev/288258ffdf21
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Depends on: 1453804
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: