141266 - Classic theme: toolbar icons for bold, italic, and underline do not update after they have been depressed.

Status: RESOLVED WORKSFORME

(SeaMonkey :: Themes, defect)

Description

[michael wendell]

On the 04-30 1.0.0 branch, and 04-30 trunk builds, if you click the icons for
bold, italic, or underline, they do not appear to be active, but only in classic
theme.

Steps to reproduce:
1. Launch browser, switch to classic theme, and restart the browser
2. Launch Composer
3. Type some text, and then click on the bold, italic, or underline icons on the
toolbar.
4. Type some more text

Actual results:
The text shows up as bold, italic, or underline, but the toolbar icon(s) do not
appear to be depressed.

Expected results:
I would expect some visual verification that the text style was applied.

Checking back on my old builds, this appears to have first showed up between the
12-30-01 trunk and 01-04-02 trunk builds.

Probably a dupe, but I could not find it.

Comment 1

[sujay]

cc: smoke tester.

Comment 2

[Tracy Walker [:tracy]]

most likely a dupe of 133666. try all your steps again except restart twice 
after switching themes.

Comment 3

[Tracy Walker [:tracy]]

I can't reproduce this at all.

Comment 4

[michael wendell]

*** Bug 141263 has been marked as a duplicate of this bug. ***

Comment 5

[michael wendell]

I am only able to reproduce this on Win XP. Mac OSX and Win 2k do not appear to
be experiencing this problem.

Comment 6

[michael wendell]

. . . and no amount of restarts appear to make a difference in the
reproducibility of this bug.  

Comment 7

[Tracy Walker [:tracy]]

ah, I do not have an XP machine.

Comment 8

[Greg Valure]

*** Bug 128164 has been marked as a duplicate of this bug. ***

Comment 9

[ajbu]

This is not about updating, but the toolbar button checked state is not visible 
on Windows XP/XP theme with Mozilla classic theme.

So if:
- Mozilla is set to the classic theme
- XP is set to the XP theme
The checked state of buttons (button is 'down')doesn't work

Comment 10

[Colin Blake]

I see this too on OpenVMS, using the classic theme. Can't believe its still not
been fixed!

This is with 1.3 final and 1.4 alpha.

Comment 11

[Tracy Walker [:tracy]]

I can reproduce this on Redhat Linux 8.0, but not on Mac OSX nor on Windows 2000.

Comment 12

[John Dobbins]

The fix for this is simple.

toolbarbutton.css sets the buttons to have a native look on platforms that
support it in these lines

toolbarbutton {
  -moz-appearance: toolbarbutton;

But the file dosent set a seperate state for checked buttons later on resulting
in the earlier setting of -moz-appearance overriding the border and background
colors that show the checked state on platforms that don't support a native look.

The Mac dosen't have this problem because it dosen't set moz-appearance on the
static state, only using it for the hover state.


Add this line:
  -moz-appearance:none !important;

Right after line 104 of mozilla/themes/classic/global/win/toolbarbutton.css
and after line 105 of mozilla/themes/classic/global/unix/toolbarbutton.css

so that they read

toolbarbutton[checked="true"] {
  -moz-appearance:none !important;
  -moz-border-top-colors: ThreeDLightShadow ThreeDShadow !important;

This will get Bold, Italic, Underline, and some of the other buttons that are
susposed to have a checked apperance working on the platforms that are having a
problem.

Comment 13

[Stefan [:stefanh]]

Looking at the style rules in toolkit/themes/global/toolbarbutton.css this looks fixed.

Comment 14

[Philip Chee]

> Looking at the style rules in toolkit/themes/global/toolbarbutton.css this looks fixed.
> Whiteboard: WFM?
I agree.