1412687 - [Layout] Prints only first page when nested aligned/floated table is longer than a page

Status: RESOLVED FIXED

(Core :: Print Preview, defect, P2)

Description

[Petr Gajdůšek]

Attachment: test.html

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

Open attached test.html which contains a "table td > div > table[align=right]" in FF 56 or 57 beta.
Open print preview.



Actual results:

Only first page of the table (with attribute align=right or style float: right) is printed.

All pages are printed if the table has style="margin: 0 0 0 auto" or if the parent div is omitted.



Expected results:

All pages should be printed as in Firefox 55 and earlier.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e6e712904806da25a9c8f48ea4533abe7c6ea8f4&tochange=d6bf703c5deaf1e328babd03d5e68ff2a4ffe10e

Regressed by: Bug 1308876

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Regression should be blocking the regressing bug rather than depending on it.

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

This may be a dupe of bug 1406291 I guess.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: simpler testcase

There is no need for the print media style sheet. The only relevance of that is that it makes the nested table big enough that it can't fit on a single page. It's simpler to simply add more content to the nested table to trigger the bug.

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: simpler testcase

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is not fixed by bug 1474771, so it needs further investigation.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1412687 - Use mMustReflowPlaceholders to enforce reflow in a paginated context.

Many printing loss issues related to the float elements are because we
don't reflow enough to break the float elements.

nsColumnFrame::ReflowChildren() uses mMustReflowPlaceholders to force
reflow children even if the column block-size is unchanged. It's similar
when we are in a paginated context, where the page size is fixed. We
also want to force reflow children, especially for frames like
nsTableRowGroupFrame that they reflow children in unconstrained
block-size to measure total block-size, and do an incremental reflow in
constrained block-size later.

Use mMustReflowPlaceholders in ShouldReflowAllKids() because we want a
overflow container child to reflow its children (can be floats) again in
nsContainerFrame::ReflowOverflowContainerChildren() even if its not
dirty.

Comment 8

[Sean Voisen (:svoisen)]

Tracking as potential print output fix for 81.

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1412687 Part 1 - Make const-cast clearer in nsTableRowGroupFrame::Reflow().

ReflowInputFlags is a struct of bitfields, so we cannot use AutoRestore to
restore its member bitfield.

Comment 10

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1412687 Part 2 - Consider an overflow container's scrollable overflow when deciding whether to reflow it.

This patch is similar to Bug 1559961 Part 2 [1]. That is, we want to reflow
an overflow container again if its scrollable overflow block-end exceeds
the available block-size constraint.

[1] https://hg.mozilla.org/mozilla-central/rev/d377ce300d0349c1b7dc562bcf5343851d36c6ed

Depends on D87629

Comment 11

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1412687 Part 3 - Add a reftest testing breaking a float in a table.

Depends on D87630

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a82bca1962a
Part 1 - Make const-cast clearer in nsTableRowGroupFrame::Reflow(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/ce14bf5310d1
Part 2 - Consider an overflow container's scrollable overflow when deciding whether to reflow it. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/fc7ac8859238
Part 3 - Add a reftest testing breaking a float in a table. r=dholbert

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25160 for changes under testing/web-platform/tests

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9a82bca1962a
https://hg.mozilla.org/mozilla-central/rev/ce14bf5310d1
https://hg.mozilla.org/mozilla-central/rev/fc7ac8859238

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot