1412712 - "Unexpected invalid url: Scratchpad/1" occur using Scratchpad for add-on debugging

Status: RESOLVED INACTIVE

(WebExtensions :: Developer Tools, defect, P5)

Description

[magicp]

Steps to reproduce:
1. Open "about:debugging"
2. Load temporary add-on (e.g. apply-css https://github.com/mdn/webextensions-examples/tree/master/apply-css)
3. Click debug button
4. Open Scratchpad
5. Run console.log('foo');
6. Check console log

Actual Results:
"Unexpected invalid url: Scratchpad/1" is logged.

Expected Results:
No errors

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=af3b8957b02d027ecf69b0a946d414ff0a91b96c&tochange=f0df4a7f6551e886388c876f0da8b2c1de86f64f

Comment 1

[Kris Maglione [:kmag]]

Note that this error is not fatal.

Stack:


Unexpected invalid url: Scratchpad/1  webextension.js:312
	WebExtensionChildActor.prototype._allowSource resource://devtools/server/actors/webextension.js:312:5
	<anonymous> self-hosted:952:17
	TabSources/this.allowSource resource://devtools/server/actors/utils/TabSources.js:32:39
	_addSource resource://devtools/server/actors/script.js:1952:10
	onNewScript resource://devtools/server/actors/script.js:1916:5
	onNewScript self-hosted:952:17
	evalWithDebugger resource://devtools/server/actors/webconsole.js:1401:16
	onEvaluateJS resource://devtools/server/actors/webconsole.js:917:20
	onEvaluateJSAsync resource://devtools/server/actors/webconsole.js:888:20
	onEvaluateJSAsync self-hosted:954:17
	onPacket resource://devtools/server/main.js:1791:15
	receiveMessage resource://devtools/shared/transport/transport.js:761:7

Comment 2

[Rob Wu [:robwu]]

The error reporting logic is still the same, so this may still happen with other fake URLs, a recent example being bug 1624503 .
https://searchfox.org/mozilla-central/rev/41c3ea3ee8eab9ce7b82932257cb80b703cbba67/devtools/server/actors/targets/webextension.js#341,351

But with the Scratchpad being gone (bug 1519103), this specific bug can be closed.