1624503 - "Unexpected invalid url: debugger eager eval code" when typing anything in the console of an extension page

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Rob Wu [:robwu]]

When I type anything in the console of the devtools in a moz-extension:-page, then I see "Unexpected invalid url: debugger eager eval code" being spammed to the global JS console.

STR:

1. Install an extension (e.g. uBlock Origin) if you don't have any extension installed.
2. Visit about:debugging and use the "Inspect" button of any extension to launch the developer tools for a moz-extension:-page (the background page in this case, but any other page would have worked).
3. Type anything, e.g. the letter b in the devtools console.
4. Look at the console. If it is empty, look at the global JS console (Ctrl-Shift-J).

Expected:

• No errors

Actual:

• The following error is repeatedly shown for every keystroke:

Unexpected invalid url: debugger eager eval code webextension.js:351
    _allowSource resource://devtools/server/actors/targets/webextension.js:351
    <anonymous> self-hosted:875
    allowSource resource://devtools/server/actors/utils/TabSources.js:37
    _addSource resource://devtools/server/actors/thread.js:1888
    onNewScript resource://devtools/server/actors/thread.js:1859
    onNewScript self-hosted:875
    getEvalResult resource://devtools/server/actors/webconsole/eval-with-debugger.js:204
    evalWithDebugger resource://devtools/server/actors/webconsole/eval-with-debugger.js:164
    evaluateJS resource://devtools/server/actors/webconsole.js:1182
    evaluateJSAsync resource://devtools/server/actors/webconsole.js:1077
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:111

Tested with Firefox Nightly 75.0a1 buildID 20200309091841 and Firefox Nightly 76.0a1 buildID 20200323092419

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1624503 - webExtensionTargetPrototype._allowSource should filter out sources related to eager eval code. r?nchevobbe!

As for sources with url "debugger eval code", webExtensionTargetPrototype._allowSource should also filter out
sources with url "debugger eager eval code" without logging any error (as it is an source.url value that we
expect and that we already know that it isn't a valid URI, and we know that those sources shouldn't be listed
in the debugger panel).

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1624503 - Added a new test case for eager eval on a WebExtension target. r?nchevobbe!

Depends on D68183

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63b614ea4a28
webExtensionTargetPrototype._allowSource should filter out sources related to eager eval code. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c3954ec53694
Added a new test case for eager eval on a WebExtension target. r=nchevobbe

Comment 5

[Razvan Maries]

Backed out for perma failures on browser_jsterm_eager_evaluation_on_webextension_target.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=295560259&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=c3954ec53694dd8e1cafe3951676f16b295f74dd&searchStr=os%2Cx%2C10.14%2Cdebug%2Ctest-macosx1014-64%2Fdebug-test-verify-e10s%2C%28tv%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295560259&repo=autoland&lineNumber=1074

Backout: https://hg.mozilla.org/integration/autoland/rev/c4100c990ddccddae62224bc575090ee78a405be

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

The test case was failing because it was pushed on autoland and ended to be applied on top of Bug 1625495's patch which has renamed "devtools/client/shared/devtools-client" to "devtools/client/devtools-client".

I'm actually glad that this didn't happen the other way around (and risk Bug 1625495 to be backed out because of the unexpected failure on the new test case added in second patch attached to this issue).

I've just updated the patch and I'll push it to autoland again asap.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21e6f132abfb
webExtensionTargetPrototype._allowSource should filter out sources related to eager eval code. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c8fc3d9a00bb
Added a new test case for eager eval on a WebExtension target. r=nchevobbe

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/21e6f132abfb
https://hg.mozilla.org/mozilla-central/rev/c8fc3d9a00bb