Closed Bug 1412918 Opened 4 years ago Closed 2 years ago

Move binscope tests in build/win32/Makefile.in to PYTHON_UNITTESTS

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1021214

People

(Reporter: ted, Unassigned)

References

(Blocks 1 open bug)

Details

We currently have a custom check rule in build/win32/Makefile.in for running binscope:
https://hg.mozilla.org/mozilla-central/file/515407ebfa1433c31144374313bbfd8b942af41c/build/win32/Makefile.in#l7

We should just move that to PYTHON_UNITTESTS and get rid of the Makefile.
Product: Core → Firefox Build System
Oh sorry, I worked on bug 1448306 without noticing this.
See Also: → 1448306
Duplicate of this bug: 1450089
No worries, it happens! I think `PYTHON_UNITTESTS` is still the right way to do this. We can make the Python file read $objdir/binaries.json to get a full list of binaries produced by the build system. Unfortunately that list also includes all the test programs we build, so we might need do to some filtering. (Simply ignoring `Test*` would probably get us most of the way there.)
(In reply to Tom Ritter [:tjr] from comment #4)
> I think we should ditch binscope and use
> https://blog.trailofbits.com/2018/09/26/effortless-security-feature-
> detection-with-winchecksec/

I guess that would replace bug 1450088.

I don't think PYTHON_UNITTESTS would be the right way to do this, especially now that many python unittests have moved out to separate tasks.
Moving the test to the build system itself, after dumping symbols, would be the easiest, and would address bug 1021214 at the same time.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1021214
You need to log in before you can comment on or make changes to this bug.