1413092 - Cleanup and move HTML 5 form validation b-c tests

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Matthew N. [:MattN]]

The form validation tests are hard to find and need some cleanup. I'll try to re-enable the one.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1413092 - Cleanup and move formValidation b-c tests.

Review commit: https://reviewboard.mozilla.org/r/194812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194812/

Comment 2

[Matthew N. [:MattN]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=705957c50d876b3ecda065d3b163fbbab7f46ed0

INFO Test verification summary for:
INFO - :::
INFO - ::: browser/modules/test/browser/formValidation/browser_validation_iframe.js
INFO - :::
INFO - ::: 1. Run each test 10 times in one browser. : Pass
INFO - ::: 2. Run each test 5 times in a new browser each time. : Pass
INFO - ::: 3. Run each test 10 times in one browser, in chaos mode. : Pass
INFO - ::: 4. Run each test 5 times in a new browser each time, in chaos mode. : Pass

INFO - ::: Test verification summary for:
INFO - :::
INFO - ::: browser/modules/test/browser/formValidation/browser_validation_invisible.js
INFO - :::
INFO - ::: 1. Run each test 10 times in one browser. : Pass
INFO - ::: 2. Run each test 5 times in a new browser each time. : Pass
INFO - ::: 3. Run each test 10 times in one browser, in chaos mode. : Pass
INFO - ::: 4. Run each test 5 times in a new browser each time, in chaos mode. : Pass
INFO - :::
INFO - ::: Test verification PASSED

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8923686 [details]
Bug 1413092 - Cleanup and move formValidation b-c tests.

https://reviewboard.mozilla.org/r/194812/#review200248

uber nit, but I don't recall many folders with capitalization in our tree. Should it be "formvalidation" instead of "formValidation"?

Either way, r+

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8923686 [details]
Bug 1413092 - Cleanup and move formValidation b-c tests.

https://reviewboard.mozilla.org/r/194812/#review200248

I also thought it was unusual but other test directories under browser/base/content/… use camel case ¯\_(ツ)_/¯

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 020e74ecf773 -d 607922c730a1: rebasing 431351:020e74ecf773 "Bug 1413092 - Cleanup and move formValidation b-c tests. r=Felipe" (tip)
merging browser/base/content/test/general/browser_bug561636.js and browser/modules/test/browser/formValidation/browser_form_validation.js to browser/modules/test/browser/formValidation/browser_form_validation.js
warning: conflicts while merging browser/modules/test/browser/formValidation/browser_form_validation.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8923686 [details]
Bug 1413092 - Cleanup and move formValidation b-c tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194812/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdebe274e971
Cleanup and move formValidation b-c tests. r=Felipe

Comment 8

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/7651a53b3faf for https://treeherder.mozilla.org/logviewer.html#?job_id=141227759&repo=autoland

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 8923686 [details]
Bug 1413092 - Cleanup and move formValidation b-c tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194812/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/929af05eb02d
Cleanup and move formValidation b-c tests. r=Felipe

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce7a90fd83a6
followup, redisable browser_validation_iframe.js, it's not quite ready yet

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/929af05eb02d
https://hg.mozilla.org/mozilla-central/rev/ce7a90fd83a6