Closed Bug 1413092 Opened 7 years ago Closed 7 years ago

Cleanup and move HTML 5 form validation b-c tests

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1413092 - Cleanup and move formValidation b-c tests.
59 bytes, text/x-review-board-request
Felipe
: review+
Details 
The form validation tests are hard to find and need some cleanup. I'll try to re-enable the one.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=705957c50d876b3ecda065d3b163fbbab7f46ed0

INFO Test verification summary for:
INFO - :::
INFO - ::: browser/modules/test/browser/formValidation/browser_validation_iframe.js
INFO - :::
INFO - ::: 1. Run each test 10 times in one browser. : Pass
INFO - ::: 2. Run each test 5 times in a new browser each time. : Pass
INFO - ::: 3. Run each test 10 times in one browser, in chaos mode. : Pass
INFO - ::: 4. Run each test 5 times in a new browser each time, in chaos mode. : Pass

INFO - ::: Test verification summary for:
INFO - :::
INFO - ::: browser/modules/test/browser/formValidation/browser_validation_invisible.js
INFO - :::
INFO - ::: 1. Run each test 10 times in one browser. : Pass
INFO - ::: 2. Run each test 5 times in a new browser each time. : Pass
INFO - ::: 3. Run each test 10 times in one browser, in chaos mode. : Pass
INFO - ::: 4. Run each test 5 times in a new browser each time, in chaos mode. : Pass
INFO - :::
INFO - ::: Test verification PASSED
Blocks: 643758
Comment on attachment 8923686 [details]
Bug 1413092 - Cleanup and move formValidation b-c tests.

https://reviewboard.mozilla.org/r/194812/#review200248

uber nit, but I don't recall many folders with capitalization in our tree. Should it be "formvalidation" instead of "formValidation"?

Either way, r+
Attachment #8923686 - Flags: review?(felipc) → review+
Comment on attachment 8923686 [details]
Bug 1413092 - Cleanup and move formValidation b-c tests.

https://reviewboard.mozilla.org/r/194812/#review200248

I also thought it was unusual but other test directories under browser/base/content/… use camel case ¯\_(ツ)_/¯
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 020e74ecf773 -d 607922c730a1: rebasing 431351:020e74ecf773 "Bug 1413092 - Cleanup and move formValidation b-c tests. r=Felipe" (tip)
merging browser/base/content/test/general/browser_bug561636.js and browser/modules/test/browser/formValidation/browser_form_validation.js to browser/modules/test/browser/formValidation/browser_form_validation.js
warning: conflicts while merging browser/modules/test/browser/formValidation/browser_form_validation.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/fdebe274e971
Cleanup and move formValidation b-c tests. r=Felipe
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/929af05eb02d
Cleanup and move formValidation b-c tests. r=Felipe
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ce7a90fd83a6
followup, redisable browser_validation_iframe.js, it's not quite ready yet
https://hg.mozilla.org/mozilla-central/rev/929af05eb02d
https://hg.mozilla.org/mozilla-central/rev/ce7a90fd83a6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: