643758 - [e10s] HTML5 validation popup doesn't close when the form element scrolls

Status: NEW

(Firefox :: Tabbed Browser, defect, P3)

Description

[accounts]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0

On submitting a blank form with, the form elements with the HTML5 attribute/value required="required" are highlighted in red and the first of such elements is given a tooltip saying "Please fill out this field."

When scrolling the page up or down with the middle mouse wheel, the tooltip remains in the same position relative to the window instead of the document. It should scroll with the document, following the element it points to, or be destroyed before the scroll. (Switching tabs or clicking anything else will cause it to be destroyed.)

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.thetruth.com/riderapp/questionnaire.cfm
2. At the bottom of the page, hit Submit
3. The window should automatically scroll to the top, first tooltip highlgihted. Scroll the middle mouse wheel up or down.
Actual Results:  
Tooltip stays in fixed position on screen.

Expected Results:  
Tooltip should be destroyed.

Standard USB mouse, wheel set to scroll three lines per notch.

Comment 1

[Simona Badau, Desktop QA]

Confirmed on: Build identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0

Comment 2

[Simona Badau, Desktop QA]

Yesterday the site displayed a tooltip but today does not, I think the source code for the website changed. Please provide another public working test case. Thanks.

Comment 3

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:2.2a1pre) Gecko/20110407 Firefox/4.2a1pre

Reporter, the indicated tooltip is no longer present. Setting resolution to Resolved Invalid.

Feel free to reopen if you run into the problem again.

Thanks!

Comment 4

[accounts]

reopened, here's a simple test page:
http://dl.dropbox.com/u/3358149/mozilla-test.html

Comment 5

[Alice0775 White]

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/136b3db3e75d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110119
Firefox/4.0b10pre ID:20110119185324
Broken:
http://hg.mozilla.org/mozilla-central/rev/9b6a73bdb237
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110119
Firefox/4.0b10pre ID:20110119205425
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=136b3db3e75d&tochange=9b6a73bdb237
Suspected:
9c96acb338ca    Felipe Gomes — Bug 597723. Mouse scrolling shouldn't dismiss
panel notifications. r=enndeakin a=blocking-final

Comment 6

[Alice0775 White]

Opposite? Bug 667506

Comment 7

[Alice0775 White]

Sorry spam

Comment 9

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0a1) Gecko/20110627 Firefox/7.0a1

On any page, the context menu invoked with right click remain active when scrolling the middle mouse wheel up and down. 
Changing the severity of this issue from trivial to normal.

Comment 12

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (Windows NT 5.1; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID 	20160711143737

I could not reproduce the issue on latest Nightly (50.0a1) so I will close the bug. If anyone can still reproduce the issue feel free to reopen the bug. 
Note: The testcases provided are no longer available so I used a new one: http://jsbin.com/vogeducijo/edit?html,output.

Comment 13

[Alice0775 White]

I cannot reproduce the problem with the testcase of comment #12 if e10s was disabled.
However, I can still reproduce the problem if e10s was enabled.

Comment 14

[Liviu Cirdei]

You're right. I tested on Windows XP which has the e10s disabled by default. 
On Windows 10 with e10s enabled I can reproduce the issue.

Comment 15

[Andrew Overholt [:overholt]]

So this isn't a regression in 50 (or even in 48) per se but is an e10s regression.

When should we focus on getting it fixed (ie. what release should we block)?

Comment 16

[Jim Mathies [:jimm]]

(In reply to Andrew Overholt [:overholt] from comment #15)
> So this isn't a regression in 50 (or even in 48) per se but is an e10s
> regression.
> 
> When should we focus on getting it fixed (ie. what release should we block)?

This was triaged as a P3 so lower priority. Basically it's up; to the module owner to prioritize.

This popup is handled by the firefox front end currently, so moving the bug over there. The popup isn't 'attached' to the form control, which we could consider the bug here.

Comment 17

[Andrew Overholt [:overholt]]

Jared, what do you think about this e10s-related bug.

Comment 18

[Jared Wein [:jaws] (please needinfo? me)]

Felipe, do you know why the "scroll" event listener isn't being triggered at http://searchfox.org/mozilla-central/source/browser/modules/FormValidationHandler.jsm#138 ?

I tried adding a "scroll" event listener in FormSubmitObserver.jsm but that didn't trigger either. I attached it to this._content and element.ownerDocument.

We could probably change this to MozScrolledAreaChanged so it would have less of a perf hit while we're here.

Comment 19

[:Felipe Gomes (needinfo for replies!)]

Hm I don't know. I just did a test here attaching a scroll listener to gBrowser.selectedBrowser and it worked properly.

Comment 20

[Andrew Overholt [:overholt]]

Consensus is we can ship without a fix here but would still love one :)

Comment 22

[Matthew N. [:MattN]]

Attachment: Bug 643758 - WIP: Close form validation popups upon scrolling with e10s

Review commit: https://reviewboard.mozilla.org/r/194834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194834/

Comment 23

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 64. We could still take a patch for 65, and if it's verified and doesn't seem risky, could still take fixes for 64 as well.

Comment 32

[alex.a.pott]

I can reproduce this bug on OS X (10.15.7) & Firefox 88.0.1 (64-bit) by going to https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation#frame_Validating_against_a_regular_expression and clicking on submit and then scrolling.

Comment 33

[Michael Hohner]

Still occurs with FF 105 and Windows 11.

Comment 34

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 12 duplicates.
:dao, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 35

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 36

[glpz]

Still relevant Validation tooltip stays static instead of next to the field

Comment 37

[milla]

Still relevant.

click on one of the "Browser Defaults" fields at https://getbootstrap.com/docs/5.0/forms/validation/#browser-defaults

Submit the form (while leaving some required fields blank). Scroll and you will notice that the error tooltip does NOT scroll with the field.

Comment 38

[Michael Hohner]

similar to bug 1809038