1413118 - [Form Autofill] Fill "tel-national" to a recognized "tel" field even the international format passes "maxlength"

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P5)

Description

[Luke Chang [:lchang] (inactive)]

It's a follow-up bug of bug 1405997.

Most websites expect the national format of a telephone number. However, they might set the "maxlength" of the field more than a valid national format (10 characters in US) because they expect the formatted number or they will help to format it after a user enters the number.

In order to better support the targeting websites, we should fill "tel-national" to a recognized "tel" field even the international format passes "maxlength" check.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1413118 - [Form Autofill] Fill "tel-national" to a recognized "tel" field even the international format passes "maxlength".

Review commit: https://reviewboard.mozilla.org/r/195720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195720/

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8924423 [details]
Bug 1413118 - [Form Autofill] Fill "tel-national" to a recognized "tel" field even the international format passes "maxlength".

https://reviewboard.mozilla.org/r/195720/#review201816

LGTM! Thanks.

::: browser/extensions/formautofill/FormAutofillHandler.jsm:341
(Diff revision 1)
>      };
>      if (element.pattern) {
>        if (testPattern(profile.tel)) {
>          return;
>        }
> -    } else if (element.maxLength) {
> +    } else if (element.maxLength && detail._reason == "autocomplete") {

checking `element.pattern` or `element.maxLength` is to make sure their existence should be considered as the first priority. If we want to follow the concept, I think the check would be better to look like this:
```JS
} else if (element.maxLength) {
  if (detail._reason == "autocomplete" && profile.tel.length <= element.maxLength) {
    return;
  }
}
```

or we can just use a simpler version:
```JS
} else if (element.maxLength && detail._reason == "autocomplete" && profile.tel.length <= element.maxLength) {
  return;
}
```

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8924423 [details]
Bug 1413118 - [Form Autofill] Fill "tel-national" to a recognized "tel" field even the international format passes "maxlength".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195720/diff/1-2/

Comment 4

[Luke Chang [:lchang] (inactive)]

Makes sense. Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c760f9b3e6c9
[Form Autofill] Fill "tel-national" to a recognized "tel" field even the international format passes "maxlength". r=seanlee

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c760f9b3e6c9

Comment 7

[Julien Cristau [:jcristau]]

The combination of "P5" and "form autofill:MVP" has me confused.  In any case, this is too late for 57, so wontfix.