Add gtk-csd tokens to configure titlebar drawing on Gtk+

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

Trunk
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(5 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
We need to configure titlebar rendering on Linux/Gtk+.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → stransky

Comment 5

2 years ago
mozreview-review
Comment on attachment 8923815 [details]
Bug 1413166 - Add gtk-csd atoms to configure rendering to titlebar on Linux/Gtk+,

https://reviewboard.mozilla.org/r/194960/#review200228
Attachment #8923815 - Flags: review?(bzbarsky) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8923816 [details]
Bug 1413166 - Bind gtk_csd* atoms with LookAndFeel,

https://reviewboard.mozilla.org/r/194962/#review200230
Attachment #8923816 - Flags: review?(bzbarsky) → review+

Comment 7

2 years ago
mozreview-review
Comment on attachment 8923817 [details]
Bug 1413166 - Export gtk_csd* atoms as media features,

https://reviewboard.mozilla.org/r/194964/#review200234

This looks fine, but needs tests that ensure that we parse these new media features properly...
Attachment #8923817 - Flags: review?(bzbarsky) → review+
Comment hidden (mozreview-request)

Comment 9

2 years ago
mozreview-review
Comment on attachment 8924140 [details]
Bug 1413166 - Added parsing tests for moz-gtk-csd-* media features,

https://reviewboard.mozilla.org/r/195392/#review200784

Ugh.  I didn't realize our coverage for this stuff got nerfed in bug 1410074.  :(

Thank you for adding these tests; I'll follow up with Emilio about adding real parseability tests here.
Attachment #8924140 - Flags: review?(bzbarsky) → review+
Given these are toggles, it shouldn't be hard to add to:

  http://searchfox.org/mozilla-central/rev/423b2522c48e1d654e30ffc337164d677f934ec3/layout/style/test/chrome/bug418986-2.js#41

To test that at least one of the possible values matches, and that resistFingerprinting works properly with them.

Comment 12

2 years ago
mozreview-review
Comment on attachment 8924502 [details]
Bug 1413166 - Added moz-gtk-csd-* media features to resistFingerprinting tests,

https://reviewboard.mozilla.org/r/195776/#review201054
Attachment #8924502 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 13

2 years ago
Thanks!
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Blocks: 1414216
(Assignee)

Updated

2 years ago
Blocks: 1414222

Comment 14

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b8671ab0719
Add gtk-csd atoms to configure rendering to titlebar on Linux/Gtk+, r=bz
https://hg.mozilla.org/integration/autoland/rev/9e5f5924dad8
Bind gtk_csd* atoms with LookAndFeel, r=bz
https://hg.mozilla.org/integration/autoland/rev/16fd21f5ad8c
Export gtk_csd* atoms as media features, r=bz
https://hg.mozilla.org/integration/autoland/rev/e1ef2adcc815
Added parsing tests for moz-gtk-csd-* media features, r=bz
https://hg.mozilla.org/integration/autoland/rev/b39bf4bf8127
Added moz-gtk-csd-* media features to resistFingerprinting tests, r=bz
Keywords: checkin-needed
(Assignee)

Comment 16

2 years ago
Will look at it, Thanks.
Flags: needinfo?(stransky)
Just for reference, you can now also add the media features to layout/style/test/chrome/test_chrome_only_media_queries.html, for a bit more complete testing.
(Assignee)

Comment 18

2 years ago
(In reply to Attila Craciun [:arny] from comment #15)
> Backed out 5 changesets (bug 1413166) for failing valgrind-test at
> Conditional jump or move depends on uninitialised value(s) at
> nsCSSRuleProcessor::InitSystemMetrics / InitSystemMetrics /
> nsCSSRuleProcessor::HasSystemMetric / GetSystemMetric
> 
> https://hg.mozilla.org/integration/autoland/rev/
> f62bd9c2b794f18f7a0eea222a592fa53d191258
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&revision=b39bf4bf81272a623d97ff797d68135ac21c6ac6&filter-
> classifiedState=unclassified&filter-resultStatus=testfailed&filter-
> resultStatus=busted&filter-resultStatus=exception
> 
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=141921820&repo=autoland&lineNumber=34355

Filed as Bug 1414774
(Assignee)

Updated

2 years ago
Depends on: 1414774
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 19

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ac985ab9e042
Add gtk-csd atoms to configure rendering to titlebar on Linux/Gtk+, r=bz
https://hg.mozilla.org/integration/autoland/rev/a319c7bef811
Bind gtk_csd* atoms with LookAndFeel, r=bz
https://hg.mozilla.org/integration/autoland/rev/7f8a59a04f19
Export gtk_csd* atoms as media features, r=bz
https://hg.mozilla.org/integration/autoland/rev/df4b8747adde
Added parsing tests for moz-gtk-csd-* media features, r=bz
https://hg.mozilla.org/integration/autoland/rev/c7dadba6ceee
Added moz-gtk-csd-* media features to resistFingerprinting tests, r=bz
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.