1413203 - The css for about:networking is not loading in Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

Go to about:networking
You will notice that there is no styling for the page.
It seems that the path chrome://mozapps/skin/aboutNetworking.css is not accessible on Android.
Not sure exactly what the approach here should be, or when this got broken.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Please help prioritize this.

Comment 2

[Wesly Huang (EPM)]

Though the css setting is not used here, the page I saw seems readible and not many item to toggle (screenshot attached)? Valentin, would you help me learn more about the expected look from a user's perspective? Thanks.

Comment 3

[Wesly Huang (EPM)]

Attachment: about networking.jpg

Comment 4

[Valentin Gosu [:valentin] (he/him)]

(In reply to Wesly Huang (Fennec Frontend/Firefox EPM) from comment #2)
> Though the css setting is not used here, the page I saw seems readible and
> not many item to toggle (screenshot attached)? Valentin, would you help me
> learn more about the expected look from a user's perspective? Thanks.

The page should look the same or similar to what it looks on desktop. (about:networking)
At least the hiding and unhiding sections should work.

Comment 5

[Wesly Huang (EPM)]

Thanks Valentin! Then all sections except "HTTP" are inaccessible comparing with Desktop, which should be fixed. rise to P2.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] Developer feature, non-critical.

Comment 7

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1413203 - The css for about:networking is not loading in Android r=Gijs

• Make about:networking work on mobile
• I used the aboutMemory.css file as a guide for doing this
• The mobile CSS does not include the common.css, since that doesn't seem to work. But at least now the interfaces is functional. We should make it look nice in a follow-up.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e81cd6ced84
The css for about:networking is not loading in Android r=Gijs

Comment 11

[Razvan Maries]

Backed out for causing perma fails on test_css_chrome_load_access.html.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-linux64-qr%2Fdebug-mochitest-e10s-12%2Cm%2812%29&revision=1e81cd6ced8435144b4daebea285d0e27ca4b0c9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271863268&repo=autoland&lineNumber=9898

Backout: https://hg.mozilla.org/integration/autoland/rev/b37f26560af018441cba447894ef75a7e8bccfcf

Comment 12

[Valentin Gosu [:valentin] (he/him)]

Fixed it. We were still referencing the old aboutNetworking.css path in that test.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7ca36975685
The css for about:networking is not loading in Android r=Gijs

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d7ca36975685

Comment 15

[Chris Peterson [:cpeterson]]

Setting status flags firefox70=wontfix and firefox-esr68=wontfix because we don't need to uplift this fix to GeckoView 70 Beta or Fennec ESR 68.

Comment 16

[Diana Rus]

Hi, verified as fixed with the link from Comment 14 on build named "geckoview_example.apk" and Fenix/Firefox Preview Nightly 101023 (Build #12960607)-GeckView 71.0a1-20191021095628 with 2 devices: Samsung Galaxy S8+ (Android 8.0.0) and Sony Xperia Z5 (Android 7.0.0).
Functionally, now when I tap on each available section from about:networking each of them display the information on both mentioned builds.

Note:

• From my point of view, the information seems to be cramped up - meaning that there is no limit between the sections and the information for them - I will put a screenshot here to see what i mean.

Comment 17

[Valentin Gosu [:valentin] (he/him)]

(In reply to Diana Rus from comment #16)

• From my point of view, the information seems to be cramped up - meaning that there is no limit between the sections and the information for them - I will put a screenshot here to see what i mean.

Thanks Diana. You are absolutely correct. I filed bug 1590671 to make it look nicer.