1413248 - nsContextMenuInfo, nsIContextMenuListener and ChromeContextMenuListener are unused or untested

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement)

Description

[Marco Castelluccio [:marco]]

Attachment: Patch that removes nsContextMenuInfo, nsIContextMenuListener and ChromeContextMenuListener

From the code coverage report, I've noticed these files/classes are not covered by tests.
Indeed, a try build with the attached patch that removes them is completely green.

Are they dead code or are they just not tested?

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch that removes nsContextMenuInfo, nsIContextMenuListener and ChromeContextMenuListener

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Huh. Spent some time in searchfox, I can't seem to find anywhere that this is used either, and it doesn't seem to show up in comm-central. The only thing holding up the rest of the context menu stuff from landing in bug 1372276 is the view source system, so maybe check that, but otherwise, if this passes try, I think we're ok to remove?

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch

(In reply to Kyle Machulis [:qdot] [:kmachulis]  (if a patch has no decent commit message, automatic r-) from comment #2)
> Huh. Spent some time in searchfox, I can't seem to find anywhere that this
> is used either, and it doesn't seem to show up in comm-central. The only
> thing holding up the rest of the context menu stuff from landing in bug
> 1372276 is the view source system, so maybe check that, but otherwise, if
> this passes try, I think we're ok to remove?

The try build is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc82a70d12757714b660fa1b3b5c631f47621cd6.
I've tested the build locally using the STR for view source from bug 1372276 comment 56 and it seems to be working fine.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8925245 [details] [diff] [review]
Patch

Review of attachment 8925245 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, cool. If this passed try and you aren't seeing any weirdness, I think we're good to prune this code. Thanks for doing this!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f41147476b0
Remove nsIContextMenuListener, nsIContextMenuListener2 and nsContextMenuInfo as they are unused. r=qdot

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8f41147476b0