1413283 - Mark ctor-constantsource.html as passing, since bug 1456266 landed

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[toy.raymond]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.18 Safari/537.36

Steps to reproduce:

n = new ConstantSourceNode(context)

Examine n.channelCount,


Actual results:

channelCount is 1.


Expected results:

channelCount should be 2.

(Not that this really matters since the channelCount applies to inputs and a ConstantSourceNode has none.)

Comment 1

[Nils Ohlmeier [:drno]]

Paul, can you please asses if this is a real problem and what's the priority?

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

I'm going to mark this as P3 becase there is no clear/immediate user impact.

Comment 3

[Paul Adenot (:padenot)]

Clearing NI.

Léo, do you want to take this one? Or maybe someone else?

Comment 4

[Léo Paquet]

(In reply to Paul Adenot (:padenot) from comment #3)
> Clearing NI.
> 
> Léo, do you want to take this one? Or maybe someone else?

Yes, I'll take it.

Comment 5

[Léo Paquet]

Attachment: Bug 1413283 - ConstantSourceNode properties incorrect.

channelCount should be 2.

Review commit: https://reviewboard.mozilla.org/r/198022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198022/

Comment 6

[Léo Paquet]

This doc is still saying "Channel count equals 1" : https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode

Comment 7

[toy.raymond]

The right place to look is https://webaudio.github.io/web-audio-api/#ConstantSourceNode, but I see that there's a spec bug that channelCount isn't mentioned here.  However, https://webaudio.github.io/web-audio-api/#dom-audionode-channelcount says the default is 2 unless otherwise stated.

Comment 8

[Paul Adenot (:padenot)]

(In reply to Léo Paquet from comment #6)
> This doc is still saying "Channel count equals 1" :
> https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode

This is a manual, and is not authoritative. That said, you can change it, it's a wiki !

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8926778 [details]
Bug 1413283 - ConstantSourceNode properties incorrect.

https://reviewboard.mozilla.org/r/198022/#review204532

Thanks! Sorry for the delay in reviewing this.

Comment 10

[Paul Adenot (:padenot)]

NI so I land this and update expectations.

Comment 11

[Paul Adenot (:padenot)]

Hrm this also has landed in bug 1456266, I'm just going to update expectations.

Comment 12

[Paul Adenot (:padenot)]

Attachment: Bug 1413283 - Remove another WPT expectation file.

Review commit: https://reviewboard.mozilla.org/r/258172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258172/

Comment 13

[Karl Tomlinson (:karlt)]

Comment on attachment 8993418 [details]
Bug 1413283 - Remove another WPT expectation file.

https://reviewboard.mozilla.org/r/258172/#review265290

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/724fef1b5487
Remove another WPT expectation file. r=karlt

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/724fef1b5487

Comment 16

[Eric Shepherd [:sheppy]]

Fixed the doc to say that ConstantSourceNode has 2 channels. Updated Firefox 63 for developers.

Comment 17

[Karl Tomlinson (:karlt)]

Fixed the doc to indicate mono output.
https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode$compare?locale=en-US&to=1403698&from=1403507
Removed channel count property from doc due to confusion.
https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode$compare?locale=en-US&to=1403699&from=1403698