Closed Bug 1413398 Opened 2 years ago Closed 2 years ago

Extend telemetry to report whether EME is used in a secure context to gecko 63

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Per Bug 1322517 comment 6,

We should extend the telemetry to gecko 63 around 2018-01-15.
Summary: Add telemetry to report whether EME is used in a secure context → Extend telemetry to report whether EME is used in a secure context to gecko 63
Comment on attachment 8942566 [details]
Bug 1413398 - Extend telemetry MEDIA_EME_SECURE_CONTEXT to gecko 63.

https://reviewboard.mozilla.org/r/212824/#review218652
Attachment #8942566 - Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14004baa6cc7
Extend telemetry MEDIA_EME_SECURE_CONTEXT to gecko 63. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/14004baa6cc7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Hi James!

Please note that extending the duration of a probe requires a new data-review (see https://wiki.mozilla.org/Firefox/Data_Collection#Requesting_Approval ) prior to landing the patch.

Cheers,
Alessio
Flags: needinfo?(jacheng)
Comment on attachment 8942566 [details]
Bug 1413398 - Extend telemetry MEDIA_EME_SECURE_CONTEXT to gecko 63.

Thanks,
I ignore it needs data review....
Though this is a minor change, I will do the data review now.
Flags: needinfo?(jacheng)
Attachment #8942566 - Flags: review+ → review?(liuche)
Comment on attachment 8942566 [details]
Bug 1413398 - Extend telemetry MEDIA_EME_SECURE_CONTEXT to gecko 63.

carry r+ from cpearce and add more reviewer for data review.
Attachment #8942566 - Flags: review+
(In reply to James Cheng[:JamesCheng] from comment #6)
> Comment on attachment 8942566 [details]
> Bug 1413398 - Extend telemetry MEDIA_EME_SECURE_CONTEXT to gecko 63.
> 
> Thanks,
> I ignore it needs data review....
> Though this is a minor change, I will do the data review now.

No problem! Thanks for requesting one now!
Comment on attachment 8942566 [details]
Bug 1413398 - Extend telemetry MEDIA_EME_SECURE_CONTEXT to gecko 63.

https://reviewboard.mozilla.org/r/212824/#review219468

data-review only, r+

Fine to extend probe in order to monitor till 2% cut-off mentioned in bug 1322517, and then remove the probe.
Attachment #8942566 - Flags: review?(liuche) → review+
You need to log in before you can comment on or make changes to this bug.