1413483 - ChannelMediaResource::CacheClientSeek() might seek to the wrong offset

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/aa1343961fca52e8c7dab16788530da31aab7c8d/dom/media/ChannelMediaResource.cpp#872

CacheClientSeek() calls Seek() which will drop |aOffset| if the resource is still suspended. When Resume() is called, it won't be able to seek to the original |aOffset| which has been lost.

We need to store |aOffset| so Resume() later can seek to the correct offset.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1413483 - add mPendingSeekOffset to store the seek offset initiated by the cache.

Seek() can't create a new channel if the resource is still suspended. we need
to store the seek offset specified by the cache so we know where to seek when
the resource is resumed.

Otherwise the new channel will download data at the wrong position and the
cache will need to run Update() and call CacheClientSeek() again which is
a waste.

Review commit: https://reviewboard.mozilla.org/r/195340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195340/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8924110 [details]
Bug 1413483 - add mPendingSeekOffset to store the seek offset initiated by the cache.

https://reviewboard.mozilla.org/r/195340/#review200416

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/346ff0f73eaa
add mPendingSeekOffset to store the seek offset initiated by the cache. r=gerald

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/346ff0f73eaa