Closed Bug 1413483 Opened 2 years ago Closed 2 years ago

ChannelMediaResource::CacheClientSeek() might seek to the wrong offset

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

http://searchfox.org/mozilla-central/rev/aa1343961fca52e8c7dab16788530da31aab7c8d/dom/media/ChannelMediaResource.cpp#872

CacheClientSeek() calls Seek() which will drop |aOffset| if the resource is still suspended. When Resume() is called, it won't be able to seek to the original |aOffset| which has been lost.

We need to store |aOffset| so Resume() later can seek to the correct offset.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8924110 - Flags: review?(gsquelart)
Comment on attachment 8924110 [details]
Bug 1413483 - add mPendingSeekOffset to store the seek offset initiated by the cache.

https://reviewboard.mozilla.org/r/195340/#review200416
Attachment #8924110 - Flags: review?(gsquelart) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/346ff0f73eaa
add mPendingSeekOffset to store the seek offset initiated by the cache. r=gerald
https://hg.mozilla.org/mozilla-central/rev/346ff0f73eaa
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1413858
You need to log in before you can comment on or make changes to this bug.