Closed Bug 1413483 Opened 2 years ago Closed 2 years ago
Media Resource::Cache Client Seek() might seek to the wrong offset
59 bytes, text/x-review-board-request
http://searchfox.org/mozilla-central/rev/aa1343961fca52e8c7dab16788530da31aab7c8d/dom/media/ChannelMediaResource.cpp#872 CacheClientSeek() calls Seek() which will drop |aOffset| if the resource is still suspended. When Resume() is called, it won't be able to seek to the original |aOffset| which has been lost. We need to store |aOffset| so Resume() later can seek to the correct offset.
Assignee: nobody → jwwang
Priority: -- → P3
Attachment #8924110 - Flags: review?(gsquelart)
Comment on attachment 8924110 [details] Bug 1413483 - add mPendingSeekOffset to store the seek offset initiated by the cache. https://reviewboard.mozilla.org/r/195340/#review200416
Attachment #8924110 - Flags: review?(gsquelart) → review+
Thanks for the review!
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/346ff0f73eaa add mPendingSeekOffset to store the seek offset initiated by the cache. r=gerald
You need to log in before you can comment on or make changes to this bug.