Closed Bug 1413642 Opened 8 years ago Closed 8 years ago

URLBar buttons need safeArea insets on the iPhone X

Categories

(Firefox for iOS :: Browser, defect, P2)

Product:
Firefox for iOS
Component:
Browser
Platform:
Other
iOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fxios 11.0 ---
fxios-v11.0 --- verified

People

(Reporter: farhan, Unassigned, Mentored)

References

Details

(Whiteboard: [good-first-bug][iPhoneX])

Attachments

(3 files)

After1
85.07 KB, image/png
Details
After2
67.92 KB, image/png
Details
Pull request
55 bytes, text/x-github-pull-request
Details | Review
When in landscape the URLBar buttons need to respect the safe area insets. Both the back button and the menu button need to be outside of the safe area insets. The same applies to the QR code button when the url bar is active.
tracking-fxios: ? → 10.0
Priority: -- → P3
Blocks: 1413720
tracking-fxios: 10.0 → 10.1
Priority: P3 → P2
Whiteboard: [good-first-bug] → [good-first-bug][iPhoneX]
Attached image After1 —
Attached image After2 —
Attached file Pull request —
merged
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verifying as fix on 11.0(9148). Safe area is respected for URL bar and the QR Scan except for a regression:Bug 1439947.
Status: RESOLVED → VERIFIED
status-fxios-v11.0: --- → verified
See Also: → 1439947
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: