Closed
Bug 1413675
Opened 7 years ago
Closed 7 years ago
Downgrade to Windows SDK 10.0.15063.0 to fix clang builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file, 1 obsolete file)
|
10.15 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
When switching to VS2017, we updated our Windows SDK to 10.0.16299.0, the latest available at the time. This SDK version contains non-conformant code that slips past MSVC but errors out on clang-cl: https://developercommunity.visualstudio.com/content/problem/132223/clang-cant-compile-wrlimplementsh.html
The Chrome team worked around this by reverting to SDK 15063.
| Comment hidden (mozreview-request) |
For posterity: Update 15.4.2 didn't change any of the files in our package. I picked it up mostly just to keep the filenames unique.
Oops, somehow I forgot to actually land the changes in bug 1407678 -- I will include this SDK version change in there.
Flags: needinfo?(dmajor)
Attachment #8924336 -
Flags: review?(core-build-config-reviews)
Instead of updating the unused vs2017.manifest's, I just deleted them.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=75220e8399a06877e9f00fbc0c107f041d6f7379&group_state=expanded&filter-searchStr=win
Assignee: nobody → dmajor
Attachment #8924336 -
Attachment is obsolete: true
Attachment #8924580 -
Flags: review?(core-build-config-reviews)
|
||
Updated•7 years ago
|
Attachment #8924580 -
Flags: review?(core-build-config-reviews) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0a99f75e8fc
Downgrade to Windows SDK 10.0.15063.0 to fix clang builds. r=froydnj
|
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/75d12f0aeb23
Keep tooltool manifests and build files in sync (Port bug 1413675: Downgrade to Windows SDK 10.0.15063.0 to fix clang builds). rs=bustage-fix
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•