Closed Bug 1413675 Opened 4 years ago Closed 4 years ago
Downgrade to Windows SDK 10
.0 .15063 .0 to fix clang builds
When switching to VS2017, we updated our Windows SDK to 10.0.16299.0, the latest available at the time. This SDK version contains non-conformant code that slips past MSVC but errors out on clang-cl: https://developercommunity.visualstudio.com/content/problem/132223/clang-cant-compile-wrlimplementsh.html The Chrome team worked around this by reverting to SDK 15063.
For posterity: Update 15.4.2 didn't change any of the files in our package. I picked it up mostly just to keep the filenames unique.
Oops, somehow I forgot to actually land the changes in bug 1407678 -- I will include this SDK version change in there.
Attachment #8924336 - Flags: review?(core-build-config-reviews)
Instead of updating the unused vs2017.manifest's, I just deleted them. https://treeherder.mozilla.org/#/jobs?repo=try&revision=75220e8399a06877e9f00fbc0c107f041d6f7379&group_state=expanded&filter-searchStr=win
Attachment #8924580 - Flags: review?(core-build-config-reviews) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0a99f75e8fc Downgrade to Windows SDK 10.0.15063.0 to fix clang builds. r=froydnj
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/75d12f0aeb23 Keep tooltool manifests and build files in sync (Port bug 1413675: Downgrade to Windows SDK 10.0.15063.0 to fix clang builds). rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.