Closed Bug 1439762 Opened 7 years ago Closed 7 years ago

Configure should fail when using clang-cl with a broken SDK

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(1 file)

clangsdk
2.47 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
10.0.16299.0 doesn't work with clang-cl (https://developercommunity.visualstudio.com/content/problem/132223/clang-cant-compile-wrlimplementsh.html) 10.0.15063.0 is what we use in automation 10.0.14393.0 is our current minimum requirement
Attached patch clangsdk — — Splinter Review
Assignee: nobody → dmajor
Attachment #8952553 - Flags: review?(nfroyd)
Comment on attachment 8952553 [details] [diff] [review] clangsdk Review of attachment 8952553 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8952553 - Flags: review?(nfroyd) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f598880f97c1 Make configure fail when using clang-cl with a broken SDK. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/f598880f97c1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Core → Firefox Build System
Blocks: 1462616
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: