Closed Bug 1439762 Opened 2 years ago Closed 2 years ago

Configure should fail when using clang-cl with a broken SDK

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

10.0.16299.0 doesn't work with clang-cl (https://developercommunity.visualstudio.com/content/problem/132223/clang-cant-compile-wrlimplementsh.html)

10.0.15063.0 is what we use in automation

10.0.14393.0 is our current minimum requirement
Attached patch clangsdkSplinter Review
Assignee: nobody → dmajor
Attachment #8952553 - Flags: review?(nfroyd)
Comment on attachment 8952553 [details] [diff] [review]
clangsdk

Review of attachment 8952553 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #8952553 - Flags: review?(nfroyd) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f598880f97c1
Make configure fail when using clang-cl with a broken SDK. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/f598880f97c1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Core → Firefox Build System
Blocks: 1462616
You need to log in before you can comment on or make changes to this bug.