1413734 - update av1 decoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Ralph Giles (:rillian)]

Bump third_party/aom to pick up changes since the last update. Unfortunately this didn't resolve the playback performance regression.

Use e87fb2378f01103d5d6e477a4ef6892dc714e614 (from October 10) to match bitmovin demo update.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1413734 - av1: Update decoder library.

Update to upstream commit id e87fb2378f01103d5d6e477a4ef6892dc714e614
from a couple of weeks ago to pick up changes.

Review commit: https://reviewboard.mozilla.org/r/195604/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195604/

Comment 2

[Ralph Giles (:rillian)]

Attachment: Bug 1413734 - av1: fix build issues.

This revision of libaom has some conflicts with our vendor script
and build system. A number of new .asm files have the same basename
as .c files, which our build system cannot handle.

To work around this, I ran `./mach vendor aom` with the check for
duplicate filenames disabled, then manually renamed the conflicting
files in the filesystem and sources.mozbuild.

Also add av1_convolve_scale_sse4.c to sources.mozbuild manually.
This is needed by the build but for some reason isn't picked up
by generate_sources_mozbuild.sh.

Review commit: https://reviewboard.mozilla.org/r/195606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195606/

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8924357 [details]
Bug 1413734 - av1: Update decoder library.

https://reviewboard.mozilla.org/r/195604/#review200792

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8924358 [details]
Bug 1413734 - av1: fix build issues.

https://reviewboard.mozilla.org/r/195606/#review200794

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8924358 [details]
Bug 1413734 - av1: fix build issues.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195606/diff/1-2/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8924357 [details]
Bug 1413734 - av1: Update decoder library.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195604/diff/1-2/

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8924358 [details]
Bug 1413734 - av1: fix build issues.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195606/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09fb1d6fdf42
av1: Update decoder library. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/db157b43675f
av1: fix build issues. r=kinetik

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/09fb1d6fdf42
https://hg.mozilla.org/mozilla-central/rev/db157b43675f