Closed Bug 1414507 Opened 2 years ago Closed 2 years ago

av1 decoder updated in bug 1413734 does not compile with VS2015 - Local Firefox/Thunderbird Windows 32 builds busted on 2017-11-04 after bug 1413734 [update av1 decoder]

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jorgk-bmo, Assigned: frg)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1413734 +++

Local build and build on the tree fail with:

 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(70): warning C4013: '_mm256_insert_epi16' undefined; assuming extern returning int
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(70): error C2718: '__m256i': actual parameter with requested alignment of 32 won't be aligned
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(70): error C2440: '=': cannot convert from 'int' to '__m256i'
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(105): error C2718: '__m256i': actual parameter with requested alignment of 32 won't be aligned
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(105): error C2440: '=': cannot convert from 'int' to '__m256i'
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(134): error C2718: '__m256i': actual parameter with requested alignment of 32 won't be aligned
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(134): error C2440: '=': cannot convert from 'int' to '__m256i'
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(190): error C2718: '__m256i': actual parameter with requested alignment of 32 won't be aligned
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(190): error C2440: '=': cannot convert from 'int' to '__m256i'
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(236): error C2718: '__m256i': actual parameter with requested alignment of 32 won't be aligned
 9:07.38 c:/mozilla-source/comm-central/mozilla/third_party/aom/aom_dsp/x86/highbd_intrapred_avx2.c(236): error C2440: '=': cannot convert from 'int' to '__m256i'
 9:07.38 c:/mozilla-source/comm-central/mozilla/config/rules.mk:781: recipe for target 'highbd_intrapred_avx2.obj' failed
 9:07.38 mozmake[4]: *** [highbd_intrapred_avx2.obj] Error 2

Local backout of
https://hg.mozilla.org/mozilla-central/rev/09fb1d6fdf42
https://hg.mozilla.org/mozilla-central/rev/db157b43675f
gets me going again.
Flags: needinfo?(mozilla)
Flags: needinfo?(kinetik)
Flags: needinfo?(giles)
Looks like Win64 is compiling which uses VS2017 but Win32 which is using VS2015 isn't.
Summary: Windows builds busted on 2017-11-04 after bug 1413734 [update av1 decoder] → Windows 32 builds busted on 2017-11-04 after bug 1413734 [update av1 decoder]
Not sure but might be a known and already fixed problem for VS2015:

https://aomedia.googlesource.com/aom/+/4c3c0f24669724df15e1e4abac9c6c3ed6dd4ab5
The Win server failing is marked Win XP. Win XP is no longer supported for application run. So maybe also building on Win XP does not make much sense? It seems m-c does not have a build server for Win XP, only Win 7 and Win 10 (and 2012). Maybe we should finally follow?
And after fixing the first one you run into this one:
https://aomedia.googlesource.com/aom/+/989dd5bf348cdd2648e243b2de2a88868878ffab
Attached patch 1414507-aomedia.patch (obsolete) — Splinter Review
This seems to fix it for me.
spoke too soon. Still seeing C2719 errors.
d:/seamonkey/comm-central/mozilla/third_party/aom/av1/common/thread_common.c(89): error C2719: 'planes': formal parameter with requested alignment of 16 won't be aligned
d:/seamonkey/comm-central/mozilla/third_party/aom/av1/common/thread_common.c(103): error C2719: 'planes': formal parameter with requested alignment of 16 won't be aligned
d:/seamonkey/comm-central/mozilla/third_party/aom/av1/common/thread_common.c(125): error C2719: 'planes': formal parameter with requested alignment of 16 won't be aligned
d:/seamonkey/comm-central/mozilla/config/rules.mk:781: recipe for target 'thread_common.obj' failed
mozmake[4]: *** [thread_common.obj] Error 2
mozmake[4]: *** Waiting for unfinished jobs....
Still building. I didn't check why the three changed defines were not in the patches.
Attachment #8925255 - Attachment is obsolete: true
Build finished. Didn't try it yet. 

See also:

https://aomedia-review.googlesource.com/#/c/aom/+/26409/1
Thanks. FF is compiling on VS2017 so there's little hope that we will use that patch. We need to get off VS2015 pronto.
As far as I know VS2015 buliding has not been deprecated yet so I still consider this an error which needs to be fixed. Otherwise the configure should complain.
Agreed. I forgot that my local VS2015 build is busted, too, since I'm distracted by bug 1414398.
Thanks, I can compile with this patch using VS2015.
Component: Build Config → Audio/Video: Playback
Product: Thunderbird → Core
Summary: Windows 32 builds busted on 2017-11-04 after bug 1413734 [update av1 decoder] → av1 decoder updated in bug 1413734 does not compile with VS2015. Was: Windows 32 builds busted on 2017-11-04 after bug 1413734 [update av1 decoder]
Summary: av1 decoder updated in bug 1413734 does not compile with VS2015. Was: Windows 32 builds busted on 2017-11-04 after bug 1413734 [update av1 decoder] → av1 decoder updated in bug 1413734 does not compile with VS2015. Was: Thunderbird Windows 32 builds busted on 2017-11-04 after bug 1413734 [update av1 decoder]
To be clear, this affects m-c firefox builds as well. I can no longer build locally.
Gijs, you can edit the subject ;-)
Summary: av1 decoder updated in bug 1413734 does not compile with VS2015. Was: Thunderbird Windows 32 builds busted on 2017-11-04 after bug 1413734 [update av1 decoder] → av1 decoder updated in bug 1413734 does not compile with VS2015 - Local Firefox/Thunderbird Windows 32 builds busted on 2017-11-04 after bug 1413734 [update av1 decoder]
Comment on attachment 8925268 [details] [diff] [review]
1414507-aomedia.patch

Review of attachment 8925268 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. If there are fixes for this which aren't upstream, can you take care of submitting them please? Otherwise this will regress the next time we vendor.
Attachment #8925268 - Flags: review+
Flags: needinfo?(giles)
Assignee: nobody → frgrahl
Flags: needinfo?(mozilla)
Flags: needinfo?(kinetik)
For the record. I downloaded
I9ca596f677e174ccd12a6e4eb927733d25e76f58 from
https://aomedia.googlesource.com/aom/+/989dd5bf348cdd2648e243b2de2a88868878ffab%5E%21/
and
Ifb6c437d8d2f309d0717fb50c402618475fe021f from
https://aomedia.googlesource.com/aom/+/4c3c0f24669724df15e1e4abac9c6c3ed6dd4ab5%5E%21/
applied them and then fixed the three compile errors at
thread_common.c(89)
thread_common.c(103)
thread_common.c(125)
and came to the exact same patch.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/4ea775c267be
Fix aom compile errors with VS2015. r=rillian, a=me
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.