1413836 - Support ShadowRootInit.delegatesFocus

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Ben Tian (inactive)]

Add ShadowRootInit.delegateFocus flag and support behavior in
https://www.w3.org/TR/shadow-dom/#focus

Comment 1

[Ben Tian (inactive)]

(In reply to Ben Tian [:btian] from comment #0)
> Add ShadowRootInit.delegateFocus flag and support behavior in
> https://www.w3.org/TR/shadow-dom/#focus

Example:
https://developers.google.com/web/fundamentals/web-components/shadowdom#focus

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Given that webkit doesn't have this, this probably doesn't need to block our initial impl,
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/dom/Element.idl#L157.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

It's fixed in Webkit now...

Comment 4

[Philip Jägenstedt [:foolip]]

Note that there's a typo which makes it hard to find this bug. It's delegatesFocus, not delegateFocus. (Maybe it was renamed after this bug was filed.)

Comment 5

[Sean Feng [:sefeng]]

Attachment: Bug 1413836 - Add delegatesFocus attribute to shadow dom r=smaug

Comment 6

[Sean Feng [:sefeng]]

Attachment: Bug 1413836 - Enable WPT for delegatesFocus r=smaug

Depends on D123858

Comment 7

[Sean Feng [:sefeng]]

Attachment: Bug 1413836 - Add a test to ensure delegatesFocus works correctly with real click on nested shadow dom trees r=smaug

Depends on D123859

Comment 8

[Sean Feng [:sefeng]]

Attachment: Bug 1413836 - Avoid nested focus steps in focus-pseudo-matches-on-shadow-host.html r=smaug

The autofocus attribute could run scripts while it's autofocusing
which may run the promise_tests, so that the focus() usage
in the tests could become nested focusing steps.

Depends on D123860

Comment 9

[Sean Feng [:sefeng]]

Attachment: Bug 1413836 - Implement the focusing steps for delegatesFocus r=smaug

Depends on D123861

Comment 10

[Sean Feng [:sefeng]]

Attachment: Bug 1413836 - Add a test to ensure :focus is removed from the hosts r=smaug

When none of the elements inside the shadow dom is focused, :focus
should be removed from the hosts.

Depends on D123862

Comment 11

[Sean Feng [:sefeng]]

Attachment: Bug 1413836 - Add a test to ensure :focus is applied to host when the focus is moved by <tab> r=smaug

Depends on D123863

Comment 12

[Sean Feng [:sefeng]]

Attachment: Bug 1413836 - Use Ahem font to avoid antialiased fringe for focus-pseudo-on-shadow-host-2.html r=dholbert

When the FAIL text goes away, there could be some antialiased fringe left which
caused the test to fail. Use Ahem font to reduce likelihood of this
happening again.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc8d5d9533e4
Add delegatesFocus attribute to shadow dom r=smaug
https://hg.mozilla.org/integration/autoland/rev/19e3256ea07c
Enable WPT for delegatesFocus r=smaug
https://hg.mozilla.org/integration/autoland/rev/c1d1d4b5ab74
Add a test to ensure delegatesFocus works correctly with real click on nested shadow dom trees r=smaug
https://hg.mozilla.org/integration/autoland/rev/d829be6f2813
Avoid nested focus steps in focus-pseudo-matches-on-shadow-host.html r=smaug
https://hg.mozilla.org/integration/autoland/rev/979fef259e32
Implement the focusing steps for delegatesFocus r=smaug
https://hg.mozilla.org/integration/autoland/rev/ae89d15d28eb
Add a test to ensure :focus is removed from the hosts r=smaug
https://hg.mozilla.org/integration/autoland/rev/dc6a694146fd
Add a test to ensure :focus is applied to host when the focus is moved by <tab> r=smaug
https://hg.mozilla.org/integration/autoland/rev/53c86681259e
Use Ahem font to avoid antialiased fringe for focus-pseudo-on-shadow-host-2.html r=dholbert

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30330 for changes under testing/web-platform/tests

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 16

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f7169baa181
Backed out 8 changesets for delegatesFocus related wpt failures. CLOSED TREE

Comment 17

[Cosmin Sabou [:CosminS]]

Backed out delegatesFocus related wpt failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel&fromchange=53c86681259e185c9c44465b4ff2851757bb2e3b&test_paths=dom&searchStr=wpt&tochange=9f7169baa181e2d8713c6d6bc66cfe6c7cc76891&selectedTaskRun=V8q_MsUHQpurboUY3JCAMA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=350471237&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/9f7169baa181e2d8713c6d6bc66cfe6c7cc76891

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9e72029c94e
Add delegatesFocus attribute to shadow dom r=smaug
https://hg.mozilla.org/integration/autoland/rev/2bb1aaa2f920
Enable WPT for delegatesFocus r=smaug
https://hg.mozilla.org/integration/autoland/rev/8f4e174e2f35
Add a test to ensure delegatesFocus works correctly with real click on nested shadow dom trees r=smaug
https://hg.mozilla.org/integration/autoland/rev/dfaef6859ed1
Avoid nested focus steps in focus-pseudo-matches-on-shadow-host.html r=smaug
https://hg.mozilla.org/integration/autoland/rev/942744e138f2
Implement the focusing steps for delegatesFocus r=smaug
https://hg.mozilla.org/integration/autoland/rev/60e18b225b15
Add a test to ensure :focus is removed from the hosts r=smaug
https://hg.mozilla.org/integration/autoland/rev/767cfea23c71
Add a test to ensure :focus is applied to host when the focus is moved by <tab> r=smaug
https://hg.mozilla.org/integration/autoland/rev/4ed1222e4288
Use Ahem font to avoid antialiased fringe for focus-pseudo-on-shadow-host-2.html r=dholbert

Comment 19

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d9e72029c94e
https://hg.mozilla.org/mozilla-central/rev/2bb1aaa2f920
https://hg.mozilla.org/mozilla-central/rev/8f4e174e2f35
https://hg.mozilla.org/mozilla-central/rev/dfaef6859ed1
https://hg.mozilla.org/mozilla-central/rev/942744e138f2
https://hg.mozilla.org/mozilla-central/rev/60e18b225b15
https://hg.mozilla.org/mozilla-central/rev/767cfea23c71
https://hg.mozilla.org/mozilla-central/rev/4ed1222e4288

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 23

[Hamish Willee]

FF94 docs work for this can be tracked in https://github.com/mdn/content/issues/9364#issuecomment-941607490. This is essentially a release note and an update to BCD.