Remove ES draft array/generator comprehensions

RESOLVED FIXED in Firefox 58

Status

()

Core
JavaScript Engine
P3
normal
RESOLVED FIXED
19 days ago
2 days ago

People

(Reporter: evilpie, Assigned: jandem)

Tracking

(Depends on: 2 bugs, Blocks: 1 bug, {dev-doc-needed, site-compat})

unspecified
mozilla58
dev-doc-needed, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

19 days ago
The "new" array/generator comprehension syntax doesn't seem to have any active proposals and is not implemented by another browser.
status-firefox57: --- → wontfix
status-firefox58: --- → affected
Priority: -- → P3
(Assignee)

Comment 1

14 days ago
Created attachment 8926351 [details] [diff] [review]
WIP

Passes shell tests.
(Assignee)

Comment 2

14 days ago
Created attachment 8926432 [details] [diff] [review]
Part 1 - Fix Gecko code
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8926432 - Flags: review?(evilpies)
(Assignee)

Comment 3

14 days ago
Created attachment 8926433 [details] [diff] [review]
Part 2 - Remove array/generator comprehensions
Attachment #8926351 - Attachment is obsolete: true
Attachment #8926433 - Flags: review?(evilpies)

Updated

14 days ago
Keywords: dev-doc-needed, site-compat
(Reporter)

Updated

14 days ago
Attachment #8926433 - Flags: review?(evilpies) → review+
(Reporter)

Comment 4

14 days ago
Comment on attachment 8926432 [details] [diff] [review]
Part 1 - Fix Gecko code

Review of attachment 8926432 [details] [diff] [review]:
-----------------------------------------------------------------

Redirecting. I wasn't sure how other people feel about the function* syntax. I thought it's a bit magically, but maybe I am not used to new-JS yet.
Attachment #8926432 - Flags: review?(evilpies) → review?(dtownsend)
Comment on attachment 8926432 [details] [diff] [review]
Part 1 - Fix Gecko code

Review of attachment 8926432 [details] [diff] [review]:
-----------------------------------------------------------------

Could have sworn that we did this already
Attachment #8926432 - Flags: review?(dtownsend) → review+

Comment 6

12 days ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71e5015934c2
part 1 - Remove non-standard array/generator comprehensions from browser code. r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/67fe0ac257b8
part 2 - Remove array/generator comprehensions from SpiderMonkey. r=evilpie
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/array-generator-comprehension-support-has-been-removed/
https://hg.mozilla.org/mozilla-central/rev/71e5015934c2
https://hg.mozilla.org/mozilla-central/rev/67fe0ac257b8
Status: ASSIGNED → RESOLVED
Last Resolved: 12 days ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1417787

Updated

2 days ago
Depends on: 1418998
You need to log in before you can comment on or make changes to this bug.