1414340 - Remove ES draft array/generator comprehensions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tom S [:evilpie]]

The "new" array/generator comprehension syntax doesn't seem to have any active proposals and is not implemented by another browser.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: WIP

Passes shell tests.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Fix Gecko code

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Remove array/generator comprehensions

Comment 4

[Tom S [:evilpie]]

Comment on attachment 8926432 [details] [diff] [review]
Part 1 - Fix Gecko code

Review of attachment 8926432 [details] [diff] [review]:
-----------------------------------------------------------------

Redirecting. I wasn't sure how other people feel about the function* syntax. I thought it's a bit magically, but maybe I am not used to new-JS yet.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8926432 [details] [diff] [review]
Part 1 - Fix Gecko code

Review of attachment 8926432 [details] [diff] [review]:
-----------------------------------------------------------------

Could have sworn that we did this already

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71e5015934c2
part 1 - Remove non-standard array/generator comprehensions from browser code. r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/67fe0ac257b8
part 2 - Remove array/generator comprehensions from SpiderMonkey. r=evilpie

Comment 7

[Kohei Yoshino]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/array-generator-comprehension-support-has-been-removed/

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71e5015934c2
https://hg.mozilla.org/mozilla-central/rev/67fe0ac257b8

Comment 9

[Florian Scholz (Open Web Docs)]

Developer release notes for 58
https://developer.mozilla.org/en-US/Firefox/Releases/58#JavaScript_2

Reference pages updated
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Array_comprehensions
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Generator_comprehensions

Compat data update
https://github.com/mdn/browser-compat-data/pull/664