Closed Bug 1414340 Opened 2 years ago Closed 2 years ago

Remove ES draft array/generator comprehensions

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: evilpie, Assigned: jandem)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files, 1 obsolete file)

The "new" array/generator comprehension syntax doesn't seem to have any active proposals and is not implemented by another browser.
Priority: -- → P3
Attached patch WIP (obsolete) — Splinter Review
Passes shell tests.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8926432 - Flags: review?(evilpies)
Attachment #8926351 - Attachment is obsolete: true
Attachment #8926433 - Flags: review?(evilpies)
Attachment #8926433 - Flags: review?(evilpies) → review+
Comment on attachment 8926432 [details] [diff] [review]
Part 1 - Fix Gecko code

Review of attachment 8926432 [details] [diff] [review]:
-----------------------------------------------------------------

Redirecting. I wasn't sure how other people feel about the function* syntax. I thought it's a bit magically, but maybe I am not used to new-JS yet.
Attachment #8926432 - Flags: review?(evilpies) → review?(dtownsend)
Comment on attachment 8926432 [details] [diff] [review]
Part 1 - Fix Gecko code

Review of attachment 8926432 [details] [diff] [review]:
-----------------------------------------------------------------

Could have sworn that we did this already
Attachment #8926432 - Flags: review?(dtownsend) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71e5015934c2
part 1 - Remove non-standard array/generator comprehensions from browser code. r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/67fe0ac257b8
part 2 - Remove array/generator comprehensions from SpiderMonkey. r=evilpie
https://hg.mozilla.org/mozilla-central/rev/71e5015934c2
https://hg.mozilla.org/mozilla-central/rev/67fe0ac257b8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1418998
You need to log in before you can comment on or make changes to this bug.