1417787 - about:healthreport (Health Report) main content is broken due to use of array comprehensions

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Web: Health Report, defect, P1)

Description

[Matthew N. [:MattN]]

[Tracking Requested - why for this release]: about:healthreport is quite broken

> SyntaxError: expected expression, got keyword 'for' fhr_v4.js:71:40

https://github.com/mozilla/fhr-jelly/blob/b6717cc2ed4671f7d16ea21683cd7bd40757a720/js/fhr_v4.js#L71-L72

Comment 1

[Gerry Chang [:gchang]]

Track 58+ as about:healthreport is broken.

Hi Georg,
Can you help shed some light here?

Comment 2

[Georg Fritzsche [:gfritzsche]]

Array comprehensions are gone in 58, we need to change the code here.

Comment 3

[Georg Fritzsche [:gfritzsche]]

PR: https://github.com/mozilla/fhr-jelly/pull/183

Comment 4

[Georg Fritzsche [:gfritzsche]]

Merged: https://github.com/mozilla/fhr-jelly/pull/183

Comment 5

[Georg Fritzsche [:gfritzsche]]

This should be on staging with the next automatic update:
http://fhr-dev.allizom.org/dsb/v4/

Comment 6

[Georg Fritzsche [:gfritzsche]]

Alessio, can you give this a test run in Fx 58 once it hits staging?

After that we need to deploy this to production. We can clone bug 1335821 for that (i think that's the most recent).

Comment 8

[Alessio Placitelli [:Dexter]]

(In reply to Georg Fritzsche [:gfritzsche] [away Nov 24 - Dec 3] from comment #6)
> Alessio, can you give this a test run in Fx 58 once it hits staging?

I can confirm that this is correctly loading in today's Nightly, while the old page is broken.

Comment 9

[Madalin Cotetiu]

I've also tested this in stage and everything looks good: the general layout, links functionality, all the pings are correctly displayed and their structure is correct.

Comment 10

[Alessio Placitelli [:Dexter]]

Thanks Madalin.

The new FHR was deployed and it's working.