1414563 - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-content-tab.js | test-content-tab.js::test_spellcheck_in_content_tabs

Status: REOPENED

(Thunderbird :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Frequently seen on Linux debug on Treeherder.

No so frequent to be really annoying, so I haven't disabled it yet. I hear that a patch is in the wings, so here's the bug ;-)

Comment 1

[:aceman]

Attachment: 1414563.patch

Green try, so at least it shouldn't make things worse:)
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d283a76f8a201c32416682edcda3a1e92d5c091b

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8925311 [details] [diff] [review]
1414563.patch

Looks good. Thanks for the "boy-scout" clean-up. You're the best person to know when to wait.

Sadly this is just the tip of the iceberg of test failures on Linux debug.

Comment 3

[Jorg K (CEST = GMT+2)]

How about
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-content-tab.js | test-content-tab.js::test_content_tab_context_menu
next, that's the second most frequent failure I haven't switched off yet (no bug yet).

Comment 4

[:aceman]

I thought that one is solved by this patch too. Yes, there is no change to the function, so it may be the test-content-tab.js::test_spellcheck_in_content_tabs affected it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b5fb9c055e0e
wait for context menu to open before poking its contents in test-content-tab.js. r=jorgk CLOSED TREE

Comment 6

[Jorg K (CEST = GMT+2)]

Sadly not 100% successful, still failing here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=b5fb9c055e0e5a890f4515099bc3a967b76f4289&selectedJob=142241545
Should we reopen the bug?

Comment 7

[Jorg K (CEST = GMT+2)]

Pretty perma-red on Linux and Windows debug.

Comment 8

[Jorg K (CEST = GMT+2)]

Latest debug try on Linux with Aceman's new patch:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=35a928fc59485bd63769dbf1373d172fa83d7fea

Comment 9

[Jorg K (CEST = GMT+2)]

Just for the record: This test is totally wrong. Spell check in M-C is async, so this code doesn't fly:
assert_true(suggestions.length > 0, "What, is zombocom a registered word now?");

Which is what we see:
EXCEPTION: What, is zombocom a registered word now?

The suggestions simply haven't arrived yet. I've written some spellcheck Mochitests for M-C once upon a time, and the right ways is to listen to some sort of event. Looking at the tests in editor/spellchecker/tests/, it's the onSpellCheck() callback. So we should wait for the spellcheck to finish before opening the context menu.