141481 - javascript strict warnings in contextHelp.js

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Morten Nilsen]

Error: redeclaration of const MOZ_HELP_URI
Source File: chrome://help/content/contextHelp.js
Line: 1

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

This isn't an error, this is a warning...

Comment 2

[Morten Nilsen]

patch in hand....
I'm rebuilding my tree at the moment, but as soon as that's done, I'll see if my
fix works.

if it does, it's a one-liner

Comment 3

[Morten Nilsen]

Attachment: oneliner fix

Comment 4

[Henrik Gemal]

*** Bug 144744 has been marked as a duplicate of this bug. ***

Comment 5

[André Dahlqvist]

I see this each time I open the mail composer window. It clutters up the
JavaScript console unnecessarily.

Comment 6

[David G King]

Morten,

Have you asked anyone for an SR?

Comment 7

[David G King]

*** Bug 151715 has been marked as a duplicate of this bug. ***

Comment 8

[Morten Nilsen]

I think I might have, but it's so long ago, I can't remember clearly...

Anyhoo, I faded out again (I keep fading in and out of active hacking in moz)
after making this and another few patches, thus it's been hanging...

*checking Sent mail*

Indeed, I did send a request for SR of the two patches in bug 138864 and this
one on Thu, 27 Jun 2002

Comment 9

[Henrik Gemal]

this is one of the few JS error we have left that should up all the time. Cant
we get it into moz1.2?

Comment 10

[Morten Nilsen]

yeah, this should have gone in back when I made the patch really... setting
keyword to hopefully get some attention :)

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Morten, you should mail the xpfe super-reviewers. see
http://mozilla.org/hacking/reviewers.html

Comment 12

[Morten Nilsen]

Sent an request for sr now...
When (if) I get it, can somebody please check it in for me? thanks.

Comment 13

[jag (Peter Annema)]

Comment on attachment 81871 [details] [diff] [review]
oneliner fix

Marking r=timeless
sr=jag

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, marking fixed.

Comment 15

[Morten Nilsen]

v