Update webrender to f58ed651b47f47382b63dd2bce6e4ed10ee18c78

RESOLVED FIXED in Firefox 58

Status

()

Core
Graphics: WebRender
P1
normal
RESOLVED FIXED
15 days ago
11 days ago

People

(Reporter: kats, Assigned: kats)

Tracking

(Blocks: 2 bugs)

58 Branch
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [wr-mvp] [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

+++ This bug was initially created as a clone of Bug #1414271 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
WR @ 24b3fa46ec628e2e07f754d87791114378a842f8

https://treeherder.mozilla.org/#/jobs?repo=try&revision=35f3a982b45e8baadf4ac0ff9c3e0c4a6d4c1c7c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c44d3f896b90074b578064db9b1f4c6803b617e

Green

WR @ aa74cdfc155d8f5b917332e6ab344fe3253c5a72

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25467114abc6adfd8be7e9bd9f00847be6e2d4ef
https://treeherder.mozilla.org/#/jobs?repo=try&revision=877f26464dc1a5d309de0eee5758e13cc4a9c5d0

One unexpected-fail in R3; it's a slight change in an already-fuzzy test. I'll update the fuzz. Regression range is below, assuming this is from servo/webrender#2010.

*   aa74cdfc Auto merge of #2010 - mephisto41:boxshadow-inset-blur, r=glennw
|\
| * eef19593 Fix inset boxshadow after doing downscale blur.
*   56d9c06b Auto merge of #2011 - mephisto41:add-downscale-blur-reftests, r=glennw
|\
| * f41bb765 Add downscale blur reftests.
* 75781111 Auto merge of #2009 - mstange:blend-color-for-everything, r=glennw
* 6d8e7f56 Use the glBlendColor approach for all subpixel text (except the WithBgColor case).
WR @ aa74cdfc155d8f5b917332e6ab344fe3253c5a72

https://treeherder.mozilla.org/#/jobs?repo=try&revision=84c7604016f8ac129d5e019388625b9ea91aaddb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=71a4726e6779ba9b24dd4187df5e0121834a205e

Green now
WR @ 8e4f5c19e6fa623e8637425c31f78079f7cdbd40

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce3d0e3c7a3f54fd55d2d597838a2156f587677b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cd06cac38edeb71257fb2ebe2d173092723301c

Green
WR @ f58ed651b47f47382b63dd2bce6e4ed10ee18c78

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c0b1ccf1d77e37467f8ad0ce5ff31b4d505d88e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a74a6cda7386846c976d440f3efcdca1a729e75

Green so far
WR @ 66ddb1f7e6291ffb26508f7d6139a87c0bb4ea17

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbb1f0a6c291df50afafb46e39452ea73a7b39a6
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffb402d6fefebf42d40c88889b97a86340fda4fe

Linux is green but windows has some sort of crasher. Doesn't look obviously WR-related but I'll need to investigate.
The WR-side regression range is this:

*   66ddb1f7 Auto merge of #2017 - demo99:filter-fix, r=glennw
|\
| * f2909b4d Add wrench tests for hue-rotate and saturate.
| * 34d75a53 Use color matrix to handle the filters of hue-rotate and saturate.
* d2569377 Auto merge of #2018 - mrobinson:fix-scrollbars, r=kvark
* 9dd1e066 Fix some issues with scrollbars

which looks pretty benign. The m-c side regression range is this:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ed94dc665071&tochange=864174ac0707
Oh my bad, there is a shader failure in the log:

03:59:53     INFO - Failed to link shader program: "ps_blend"
03:59:53     INFO - C:\fakepath(2273,1-2): error X3004: undeclared identifier '_c'
03:59:53     INFO - Warning: D3D shader compilation failed with default flags. (vs_5_0)
03:59:53     INFO -  Retrying with skip validation
03:59:53     INFO - C:\fakepath(2273,1-2): error X3004: undeclared identifier '_c'
03:59:53     INFO - Warning: D3D shader compilation failed with skip validation flags. (vs_5_0)
03:59:53     INFO -  Retrying with skip optimization
03:59:53     INFO - C:\fakepath(2273,1-2): error X3004: undeclared identifier '_c'
03:59:53     INFO - Warning: D3D shader compilation failed with skip optimization flags. (vs_5_0)
03:59:53     INFO - Failed to create D3D shaders.
03:59:53     INFO -  Failed to render: Shader(Link("ps_blend", "C:\\fakepath(2273,1-2): error X3004: undeclared identifier \'_c\'\n\nWarning: D3D shader compilation failed with default flags. (vs_5_0)\n Retrying with skip validation\nC:\\fakepath(2273,1-2): error X3004: undeclared identifier \'_c\'\n\nWarning: D3D shader compilation failed with skip validation flags. (vs_5_0)\n Retrying with skip optimization\nC:\\fakepath(2273,1-2): error X3004: undeclared identifier \'_c\'\n\nWarning: D3D shader compilation failed with skip optimization flags. (vs_5_0)\n\n\n\nFailed to create D3D shaders.\n"))
03:59:53     INFO - [GFX1-]: wr_renderer_render: Shader(Link("ps_blend", "C:\\fakepath(2273,1-2): error X3004: undeclared identifier \'_c\'\n\nWarning: D3D shader compilation failed with default flags. (vs_5_0)\n Retrying with skip validation\nC:\\fakepath(2273,1-2): error X3004: undeclared identifier \'_c\'\n\nWarning: D3D shader compilation failed with skip validation flags. (vs_5_0)\n Retrying with skip optimization\nC:\\fakepath(2273,1-2): error X3004: undeclared identifier \'_c\'\n\nWarning: D3D shader compilation failed with skip optimization flags. (vs_5_0)\n\n\n\nFailed to create D3D shaders.\n"))

Guessing regression from servo/webrender#2017.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=26e0d5725c64700dea949108c41c1eecd22ed0b5 has the new webrender on the old m-c and also has the crashes. I'm doing try pushes with the older WR on the latest m-c just to verify that it's still green; if it is I'll put the patches up for landing.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ebad9fd99ba28cf429c0c7ce95bd574c5c54c19
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d28ab125f945071731c18e683f8d08078bd7003
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to f58ed651b47f47382b63dd2bce6e4ed10ee18c78
Version: unspecified → 58 Branch
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 12

12 days ago
mozreview-review
Comment on attachment 8927361 [details]
Bug 1415150 - Update reftest result for changes in WR PR 2010.

https://reviewboard.mozilla.org/r/198676/#review203784
Attachment #8927361 - Flags: review?(jmuizelaar) → review+

Comment 13

12 days ago
mozreview-review
Comment on attachment 8927360 [details]
Bug 1415150 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/198674/#review203786
Attachment #8927360 - Flags: review?(jmuizelaar) → review+

Comment 14

12 days ago
mozreview-review
Comment on attachment 8927359 [details]
Bug 1415150 - Update webrender to commit f58ed651b47f47382b63dd2bce6e4ed10ee18c78.

https://reviewboard.mozilla.org/r/198672/#review203788
Attachment #8927359 - Flags: review?(jmuizelaar) → review+

Comment 15

12 days ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1aec254e3c6
Update webrender to commit f58ed651b47f47382b63dd2bce6e4ed10ee18c78. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/d6857ce95bb6
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/9ed9a315436b
Update reftest result for changes in WR PR 2010. r=jrmuizel

Updated

12 days ago
Status: NEW → ASSIGNED
Priority: P2 → P1
https://hg.mozilla.org/mozilla-central/rev/c1aec254e3c6
https://hg.mozilla.org/mozilla-central/rev/d6857ce95bb6
https://hg.mozilla.org/mozilla-central/rev/9ed9a315436b
Status: ASSIGNED → RESOLVED
Last Resolved: 12 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Blocks: 1371838
You need to log in before you can comment on or make changes to this bug.