1371838 - Register WebRender threads with the Gecko profiler

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Markus Stange [:mstange]]

WebRender launches a few threads internally. We'd like to be able to profile them, so we need to call functions on thread creation + destruction in order to register + unregister them with the Gecko Profiler.

Comment 1

[Markus Stange [:mstange]]

Attachment: proof of concept

This works but needs lots of cleanup, and comments, and the rust parts should be rewritten by somebody who actually knows rust.

Comment 2

[Markus Stange [:mstange]]

Peter, would you like to take this over and finish it?

Comment 3

[Peter Chang[:pchang]]

Sure, I can help on this.

Comment 4

[Markus Stange [:mstange]]

Attachment: rebased

It doesn't seem to be capturing any WebRender:WorkerThreads. I haven't checked why that is.

Comment 5

[Peter Chang[:pchang]]

With attachment 8917973 [details] [diff] [review], I'm able to capture WebRender::Backend but not WebRender::WorkerThreads too. I will clean up the patches for landing first because we need this bug for performance profiling.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Any update on how this is going? It would be good to land sooner rather than later.

Comment 7

[Peter Chang[:pchang]]

I think we need to modify here to capture WebRender::WorkerThreads.

http://searchfox.org/mozilla-central/source/gfx/webrender_bindings/src/bindings.rs#597

Comment 8

[Jerry Shih[:jerry] (UTC+8) (inactive)]

I will take the remaining works.

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

The WR's pr:
https://github.com/servo/webrender/pull/2014

Comment 10

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: P1: export the gecko profiler registering function to WR.

MozReview-Commit-ID: 2gVAmU2xomP

Comment 11

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: P2: register the WR thread pool's thread to gecko profiler.

MozReview-Commit-ID: BUyTq2vz3cO

Comment 12

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: P3: add a custom thread lister to WR.

MozReview-Commit-ID: yyFwBr21F3

Comment 13

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: P4: set the window_id as renderer_id to WR.

MozReview-Commit-ID: 7YbQNzTNpmE

Comment 14

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: P3: add a custom thread listener to WR. v2

fix typo.

Comment 15

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: WR changes

MozReview-Commit-ID: 5mIoBmz59SR

Comment 16

[Jerry Shih[:jerry] (UTC+8) (inactive)]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=df92bd8a3c1da3c4d0543db050d9b78d864f3396

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e69fae378b7
export the gecko profiler registering function to WR. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6ad193d398e
register the WR thread pool's thread to gecko profiler. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fe8d225b7ba
add a custom thread listener to WR. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/d352680181fc
set the window_id as renderer_id to WR. r=jrmuizel

Comment 18

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8e69fae378b7
https://hg.mozilla.org/mozilla-central/rev/a6ad193d398e
https://hg.mozilla.org/mozilla-central/rev/3fe8d225b7ba
https://hg.mozilla.org/mozilla-central/rev/d352680181fc