Closed
Bug 1415265
Opened 7 years ago
Closed 6 years ago
Investigate replacing most of the .eslintrc.js files in test directories with settings in the root .eslintrc.js file based on glob configuration
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P2)
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
ESLint 4 has the capability to do glob-based configurations for files:
https://eslint.org/docs/user-guide/configuring#configuration-based-on-glob-patterns
We should see if we can make this apply to all our test directories where we're setting up environments.
Generally we should be able to pattern-match on "browser", "chrome", "unit" etc, but we might have to add some special cases :-(
|
Assignee | |
Comment 1•7 years ago
|
||
Oops, this is already bug 1379669.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Comment 2•7 years ago
|
||
Not quite a duplicate of bug 1379669.
That bug is for configuration within directories, this is for applying to directories generally based on glob configurations.
As per the hidden discussion on that bug, this is currently blocked as ESLint doesn't support the "overrides" option within "extends", see https://github.com/eslint/eslint/issues/8813 for details.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
See Also: → https://github.com/eslint/eslint/issues/8813
Whiteboard: [p5 due to being blocked]
|
|
Assignee | |
Updated•7 years ago
|
Status: REOPENED → NEW
Whiteboard: [p5 due to being blocked]
|
||
Updated•7 years ago
|
Product: Testing → Firefox Build System
|
||
Updated•6 years ago
|
Version: Version 3 → 3 Branch
|
|
Assignee | |
Comment 3•6 years ago
|
||
A way of doing this came up in the ESLint issue, so I'm investigating it at the moment.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
Depends on D23849
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d5929144262
Implement a central configuration for setting ESLint environments for test directories. r=mossop
https://hg.mozilla.org/integration/autoland/rev/2b85a797a7ca
Remove now unnecessary .eslintrc.js files or entries. r=mossop
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7d5929144262
https://hg.mozilla.org/mozilla-central/rev/2b85a797a7ca
Status: ASSIGNED → RESOLVED
Closed: 7 years ago → 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•