Closed Bug 1415265 Opened 3 years ago Closed 1 year ago

Investigate replacing most of the .eslintrc.js files in test directories with settings in the root .eslintrc.js file based on glob configuration

Categories

(Firefox Build System :: Lint and Formatting, enhancement, P2)

3 Branch
enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

ESLint 4 has the capability to do glob-based configurations for files:

https://eslint.org/docs/user-guide/configuring#configuration-based-on-glob-patterns

We should see if we can make this apply to all our test directories where we're setting up environments.

Generally we should be able to pattern-match on "browser", "chrome", "unit" etc, but we might have to add some special cases :-(
Oops, this is already bug 1379669.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1379669
Not quite a duplicate of bug 1379669.

That bug is for configuration within directories, this is for applying to directories generally based on glob configurations.

As per the hidden discussion on that bug, this is currently blocked as ESLint doesn't support the "overrides" option within "extends", see https://github.com/eslint/eslint/issues/8813 for details.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Whiteboard: [p5 due to being blocked]
Status: REOPENED → NEW
Whiteboard: [p5 due to being blocked]
Blocks: 1379669
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch

A way of doing this came up in the ESLint issue, so I'm investigating it at the moment.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Depends on: 1535708
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d5929144262
Implement a central configuration for setting ESLint environments for test directories. r=mossop
https://hg.mozilla.org/integration/autoland/rev/2b85a797a7ca
Remove now unnecessary .eslintrc.js files or entries. r=mossop
Status: ASSIGNED → RESOLVED
Closed: 3 years ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.