Closed Bug 1456939 Opened 8 years ago Closed 4 years ago

[eslint] Disable no-unused-vars in the global scope for testing head.js files

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Version:
3 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kmag, Assigned: standard8)

References

Details

(Whiteboard: [fixed by bug 1415265])

head.js files for tests typically define a lot of symbols for use by tests that they don't reference themselves. That tends to require a lot of unnecessary bookkeeping, marking them all as exported, which doesn't really gain us anything. It might be nice to add some kind of analysis for head.js globals that aren't used by *any* tests in the future, but in the mean time, the no-unused-global-vars rule doesn't buy us anything. When this is done, we should also remove the existing /* exported */ comments, and the `// eslint-disable-next-line no-unused-vars` added in bug 1456686.
Version: Version 3 → 3 Branch
Summary: Disable no-unused-vars in the global scope for testing head.js files → [eslint] Disable no-unused-vars in the global scope for testing head.js files

Turns out we fixed this ages ago in bug 1415265.

Assignee: nobody → standard8
Status: NEW → RESOLVED
Closed: 4 years ago
Depends on: 1415265
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1415265]
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.