Closed Bug 1415283 Opened 3 years ago Closed 3 years ago
.https .html | insert DTMF with duration greater than 6000 should be clamped to 6000 - assert _approx _equals: Expect tonechange event for "" to be fired approximately after 6070 seconds expected 6070 +/- 15
59 bytes, text/x-review-board-request
+++ This bug was initially created as a clone of Bug #1411822 +++ https://treeherder.mozilla.org/logviewer.html#?job_id=142751449&repo=mozilla-inbound [task 2017-11-07T17:01:21.931Z] 17:01:21 INFO - TEST-UNEXPECTED-FAIL | /webrtc/RTCDTMFSender-ontonechange-long.https.html | insertDTMF with duration greater than 6000 should be clamped to 6000 - assert_approx_equals: Expect tonechange event for "" to be fired approximately after 6070 seconds expected 6070 +/- 150 but got 6236 [task 2017-11-07T17:01:21.931Z] 17:01:21 INFO - test_tone_change_events/</</onToneChange<@https://web-platform.test:8443/webrtc/RTCDTMFSender-helper.js:79:9 [task 2017-11-07T17:01:21.932Z] 17:01:21 INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1489:20 [task 2017-11-07T17:01:21.933Z] 17:01:21 INFO - Test.prototype.step_func/<@https://web-platform.test:8443/resources/testharness.js:1513:20 [task 2017-11-07T17:01:21.933Z] 17:01:21 INFO - TEST-OK | /webrtc/RTCDTMFSender-ontonechange-long.https.html | took 6893ms
Looks like even 150 extra seconds is not enough. Dan, Michel: is it possible that this is maybe some kind of bug in our implementation?
Priority: -- → P3
The message in that test is incorrect, the values in the test are milliseconds not seconds, so that is 150 extra milliseconds and we only missed by 6 milliseconds. I'll look into getting the test fixed and add a longer timeout.
Assignee: nobody → dminor
Comment on attachment 8926345 [details] Bug 1415283 - Increase timeout for tone events in RTCDTMFSender-helper.js; https://reviewboard.mozilla.org/r/197612/#review202890
Attachment #8926345 - Flags: review?(james) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/dcf4f46ab589 Increase timeout for tone events in RTCDTMFSender-helper.js; r=jgraham
You need to log in before you can comment on or make changes to this bug.