1415283 - Intermittent /webrtc/RTCDTMFSender-ontonechange-long.https.html | insertDTMF with duration greater than 6000 should be clamped to 6000 - assert_approx_equals: Expect tonechange event for "" to be fired approximately after 6070 seconds expected 6070 +/- 15

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

+++ This bug was initially created as a clone of Bug #1411822 +++

https://treeherder.mozilla.org/logviewer.html#?job_id=142751449&repo=mozilla-inbound

[task 2017-11-07T17:01:21.931Z] 17:01:21     INFO - TEST-UNEXPECTED-FAIL | /webrtc/RTCDTMFSender-ontonechange-long.https.html | insertDTMF with duration greater than 6000 should be clamped to 6000 - assert_approx_equals: Expect tonechange event for "" to be fired approximately after 6070 seconds expected 6070 +/- 150 but got 6236
[task 2017-11-07T17:01:21.931Z] 17:01:21     INFO - test_tone_change_events/</</onToneChange<@https://web-platform.test:8443/webrtc/RTCDTMFSender-helper.js:79:9
[task 2017-11-07T17:01:21.932Z] 17:01:21     INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1489:20
[task 2017-11-07T17:01:21.933Z] 17:01:21     INFO - Test.prototype.step_func/<@https://web-platform.test:8443/resources/testharness.js:1513:20
[task 2017-11-07T17:01:21.933Z] 17:01:21     INFO - TEST-OK | /webrtc/RTCDTMFSender-ontonechange-long.https.html | took 6893ms

Comment 1

[Nils Ohlmeier [:drno]]

Looks like even 150 extra seconds is not enough.
Dan, Michel: is it possible that this is maybe some kind of bug in our implementation?

Comment 2

[Dan Minor [:dminor]]

The message in that test is incorrect, the values in the test are milliseconds not seconds, so that is 150 extra milliseconds and we only missed by 6 milliseconds. I'll look into getting the test fixed and add a longer timeout.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1415283 - Increase timeout for tone events in RTCDTMFSender-helper.js;

With the current value of 150 milliseconds we get intermittent timeouts on our
test infrastructure. We are missing by only a small amount, e.g. 6 milliseconds
in Bug 1415283, but it seems safer to increase the timeout to 250 milliseconds so
that we don't end up revisiting this problem in the future.

This also fixes the error message to say milliseconds rather than seconds.

Review commit: https://reviewboard.mozilla.org/r/197612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197612/

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8926345 [details]
Bug 1415283 - Increase timeout for tone events in RTCDTMFSender-helper.js;

https://reviewboard.mozilla.org/r/197612/#review202890

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcf4f46ab589
Increase timeout for tone events in RTCDTMFSender-helper.js; r=jgraham

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dcf4f46ab589

Comment 7

[Intermittent Failures Robot]

3 failures in 849 pushes (0.004 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 2
* autoland: 1

Platform breakdown:
* linux32-stylo-disabled: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1415283&startday=2017-11-06&endday=2017-11-12&tree=all