Intermittent /webrtc/RTCDTMFSender-ontonechange-long.https.html | insertDTMF with duration greater than 6000 should be clamped to 6000 - assert_approx_equals: Expect tonechange event for "" to be fired approximately after 6070 seconds expected 6070 +/- 15

RESOLVED FIXED in Firefox 58

Status

()

defect
P3
normal
Rank:
25
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aryx, Assigned: dminor)

Tracking

({intermittent-failure})

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1411822 +++

https://treeherder.mozilla.org/logviewer.html#?job_id=142751449&repo=mozilla-inbound

[task 2017-11-07T17:01:21.931Z] 17:01:21     INFO - TEST-UNEXPECTED-FAIL | /webrtc/RTCDTMFSender-ontonechange-long.https.html | insertDTMF with duration greater than 6000 should be clamped to 6000 - assert_approx_equals: Expect tonechange event for "" to be fired approximately after 6070 seconds expected 6070 +/- 150 but got 6236
[task 2017-11-07T17:01:21.931Z] 17:01:21     INFO - test_tone_change_events/</</onToneChange<@https://web-platform.test:8443/webrtc/RTCDTMFSender-helper.js:79:9
[task 2017-11-07T17:01:21.932Z] 17:01:21     INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1489:20
[task 2017-11-07T17:01:21.933Z] 17:01:21     INFO - Test.prototype.step_func/<@https://web-platform.test:8443/resources/testharness.js:1513:20
[task 2017-11-07T17:01:21.933Z] 17:01:21     INFO - TEST-OK | /webrtc/RTCDTMFSender-ontonechange-long.https.html | took 6893ms
Looks like even 150 extra seconds is not enough.
Dan, Michel: is it possible that this is maybe some kind of bug in our implementation?
Rank: 25
Flags: needinfo?(mfroman)
Flags: needinfo?(dminor)
Priority: -- → P3
The message in that test is incorrect, the values in the test are milliseconds not seconds, so that is 150 extra milliseconds and we only missed by 6 milliseconds. I'll look into getting the test fixed and add a longer timeout.
Assignee: nobody → dminor
Flags: needinfo?(dminor)
Flags: needinfo?(mfroman)
Comment on attachment 8926345 [details]
Bug 1415283 - Increase timeout for tone events in RTCDTMFSender-helper.js;

https://reviewboard.mozilla.org/r/197612/#review202890
Attachment #8926345 - Flags: review?(james) → review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcf4f46ab589
Increase timeout for tone events in RTCDTMFSender-helper.js; r=jgraham
https://hg.mozilla.org/mozilla-central/rev/dcf4f46ab589
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.