1415407 - Add webrender support for filters (hue-rotate, opacity, saturate)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Ethan Lin[:ethlin]]

Webrender already implements hue-rotate, opacity and saturate. So I just need to wire them up for webrender. I know there might be some webrender work for fixing the reftest failures.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Bug 1415407 - Add webrender support for filters (hue-rotate, opacity, saturate).

Review commit: https://reviewboard.mozilla.org/r/197490/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197490/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8926228 [details]
Bug 1415407 - Add webrender support for filters (hue-rotate, opacity, saturate).

https://reviewboard.mozilla.org/r/197490/#review202698


C/C++ static analysis found 0 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8926228 [details]
Bug 1415407 - Add webrender support for filters (hue-rotate, opacity, saturate).

https://reviewboard.mozilla.org/r/197490/#review202878

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Can this wait until January?

Comment 5

[Markus Stange [:mstange]]

Huh? The patch is already up and reviewed and it's really simple.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

What about the "I know there might be some webrender work for fixing the reftest failures."?  Is this patch the end of it?  If it is, great.

Comment 7

[Markus Stange [:mstange]]

Oh, I see.

Comment 8

[Ethan Lin[:ethlin]]

The wr change seems to be simple. I just sent a PR: https://github.com/servo/webrender/pull/2017. If there is no other concern, I hope we can land this patch.

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

If we have everything working, absolutely we should land it.

Comment 10

[Ethan Lin[:ethlin]]

Attachment: Bug 1415407 - Update annotations for related tests.

Review commit: https://reviewboard.mozilla.org/r/199642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199642/

Comment 11

[Ethan Lin[:ethlin]]

Comment on attachment 8926228 [details]
Bug 1415407 - Add webrender support for filters (hue-rotate, opacity, saturate).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197490/diff/1-2/

Comment 12

[Ethan Lin[:ethlin]]

It's still waiting for the WR update. I update the annotations based on this try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=521dedec24e72e5766ffeb8f02dccb459e29fa27&selectedJob=144532714.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

(In reply to Ethan Lin[:ethlin] from comment #12)
> It's still waiting for the WR update. I update the annotations based on this
> try push:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=521dedec24e72e5766ffeb8f02dccb459e29fa27&selectedJob=1
> 44532714.

I don't think this is the right try push. I couldn't find the one you meant so I did a new one based on tip and with your first patch applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=780645b476da4ce679529e435029be6d4b04c785

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8928417 [details]
Bug 1415407 - Update annotations for related tests.

https://reviewboard.mozilla.org/r/199642/#review204864

Based on the try push I did, there are three more failures than what you annotated: hue-rotate-grad.html, hue-rotate-rad.html, and hue-rotate-turn.html. The first one might be fuzzy, but the other two are the wrong color and so probably failures.

Comment 16

[Ethan Lin[:ethlin]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #15)
> Comment on attachment 8928417 [details]
> Bug 1415407 - Update annotations for related test.
> 
> https://reviewboard.mozilla.org/r/199642/#review204864
> 
> Based on the try push I did, there are three more failures than what you
> annotated: hue-rotate-grad.html, hue-rotate-rad.html, and
> hue-rotate-turn.html. The first one might be fuzzy, but the other two are
> the wrong color and so probably failures.

Sorry, the try push should be this one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca4753a3913013cdc80bd5cbba81f2213ce9ae51.

The first patch has a small bug. I'll update the patch and send a try push again.

Comment 17

[Ethan Lin[:ethlin]]

Comment on attachment 8926228 [details]
Bug 1415407 - Add webrender support for filters (hue-rotate, opacity, saturate).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197490/diff/2-3/

Comment 18

[Ethan Lin[:ethlin]]

Comment on attachment 8928417 [details]
Bug 1415407 - Update annotations for related tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199642/diff/1-2/

Comment 19

[Ethan Lin[:ethlin]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8fcceb9972af40fb85b656f1d57383e86846322

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8928417 [details]
Bug 1415407 - Update annotations for related tests.

https://reviewboard.mozilla.org/r/199642/#review204918

Comment 21

[Markus Stange [:mstange]]

Does this fix bug 1408116?

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60ed7a647f38
Add webrender support for filters (hue-rotate, opacity, saturate). r=kats
https://hg.mozilla.org/integration/autoland/rev/b73b29bfcbde
Update annotations for related tests. r=kats

Comment 23

[Ethan Lin[:ethlin]]

(In reply to Markus Stange [:mstange] from comment #21)
> Does this fix bug 1408116?

No, this PR[1] should fix bug 1408116.

[1] https://github.com/servo/webrender/pull/2048

Comment 24

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/60ed7a647f38
https://hg.mozilla.org/mozilla-central/rev/b73b29bfcbde