1415827 - Update our in-tree ICU to 60.2

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, task, P2)

Description

[André Bargull [:anba]]

Apply the patch for http://bugs.icu-project.org/trac/ticket/13462 to correct the script properties for U+3000, U+3004, U+3012, U+3020, and U+3036 in ICU60. 

The patch will be necessary to fix some test262 failures for RegExp Unicode property escapes (bug 1361876).

Comment 1

[André Bargull [:anba]]

I wonder if we should also backport this commit <http://bugs.icu-project.org/trac/changeset/40670/trunk/icu4c> given that the updated code seems to be used by us (at least it looks like that when looking at our coverage data).

Comment 2

[André Bargull [:anba]]

Attachment: bug1415827.patch

Imports two changesets from upstream:

- https://ssl.icu-project.org/trac/changeset/40670 <https://ssl.icu-project.org/trac/ticket/13457>
- https://ssl.icu-project.org/trac/changeset/40667 <https://ssl.icu-project.org/trac/ticket/13462>

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de0a3a0dc4e40076356c589e23860fa74f1a2e64

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a866e058c608
Import two ICU patches from upstream. r=Waldo

Comment 5

[Eliza Balazs [:ebalazs_]]

Backed out changeset a866e058c608 (bug 1415827) for build bustage at intl/icu/source/i18n/calendar.cpp:711:16 r=backout 

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a866e058c6080db97aba0eac3a99369b8f93a230&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&selectedJob=148770197

https://hg.mozilla.org/integration/mozilla-inbound/rev/99667f7d7386bb2445f45bf88faad3c73e1cac1b

Comment 6

[André Bargull [:anba]]

Hmm, I'll guess I just drop the patch for https://ssl.icu-project.org/trac/ticket/13457 and report upstream that the patch doesn't compile for all compilers resp. with certain compiler flags...

Comment 7

[André Bargull [:anba]]

Added a comment to [1] to notify the ICU team that the patch won't compile under GCC4.9. 

[1] https://ssl.icu-project.org/trac/ticket/13489#comment:4

Comment 8

[André Bargull [:anba]]

Comment on attachment 8930044 [details] [diff] [review]
bug1415827.patch

There will be an ICU maintenance release (60.2) which includes both patches. It's already tagged in svn [1], but the official release date is next week (2017-12-11) [2]. Therefore marking the current patch as obsolete and instead we'll update to 60.2.

[1] https://ssl.icu-project.org/trac/browser/tags/release-60-2/icu4c
[2] http://site.icu-project.org/download/60#TOC-ICU4C-Download

Comment 9

[André Bargull [:anba]]

Update title to reflect the new goal of this bug.

Comment 10

[André Bargull [:anba]]

Attachment: bug1415827-part1-gcc4.9-workaround.patch

Applies the current patch at http://bugs.icu-project.org/trac/ticket/13511 for AIX and uses it for all platforms to ensure the code compiles under GCC-4.9.

Comment 11

[André Bargull [:anba]]

Attachment: bug1415827-part2-update-icu.patch

Updates to ICU 60.2.

Comment 12

[André Bargull [:anba]]

ICU made a new 60.2 release which already includes the GCC4.9 workaround from comment #10.

Comment 13

[André Bargull [:anba]]

Attachment: bug1415827.patch

Updates ICU to release 60.2

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5241bdbfa0a5
Update in-tree ICU to release 60.2. rs=Waldo

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5241bdbfa0a5