Closed Bug 1415827 Opened 3 years ago Closed 2 years ago
Update our in-tree ICU to 60
Apply the patch for http://bugs.icu-project.org/trac/ticket/13462 to correct the script properties for U+3000, U+3004, U+3012, U+3020, and U+3036 in ICU60. The patch will be necessary to fix some test262 failures for RegExp Unicode property escapes (bug 1361876).
I wonder if we should also backport this commit <http://bugs.icu-project.org/trac/changeset/40670/trunk/icu4c> given that the updated code seems to be used by us (at least it looks like that when looking at our coverage data).
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Imports two changesets from upstream: - https://ssl.icu-project.org/trac/changeset/40670 <https://ssl.icu-project.org/trac/ticket/13457> - https://ssl.icu-project.org/trac/changeset/40667 <https://ssl.icu-project.org/trac/ticket/13462>
Attachment #8930044 - Flags: review?(jwalden+bmo)
Attachment #8930044 - Flags: review?(jwalden+bmo) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a866e058c608 Import two ICU patches from upstream. r=Waldo
Backed out changeset a866e058c608 (bug 1415827) for build bustage at intl/icu/source/i18n/calendar.cpp:711:16 r=backout https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a866e058c6080db97aba0eac3a99369b8f93a230&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&selectedJob=148770197 https://hg.mozilla.org/integration/mozilla-inbound/rev/99667f7d7386bb2445f45bf88faad3c73e1cac1b
Hmm, I'll guess I just drop the patch for https://ssl.icu-project.org/trac/ticket/13457 and report upstream that the patch doesn't compile for all compilers resp. with certain compiler flags...
Added a comment to  to notify the ICU team that the patch won't compile under GCC4.9.  https://ssl.icu-project.org/trac/ticket/13489#comment:4
Comment on attachment 8930044 [details] [diff] [review] bug1415827.patch There will be an ICU maintenance release (60.2) which includes both patches. It's already tagged in svn , but the official release date is next week (2017-12-11) . Therefore marking the current patch as obsolete and instead we'll update to 60.2.  https://ssl.icu-project.org/trac/browser/tags/release-60-2/icu4c  http://site.icu-project.org/download/60#TOC-ICU4C-Download
Attachment #8930044 - Attachment is obsolete: true
Update title to reflect the new goal of this bug.
Summary: Add patch for ICU ticket 13462 → Update our in-tree ICU to 60.2
Applies the current patch at http://bugs.icu-project.org/trac/ticket/13511 for AIX and uses it for all platforms to ensure the code compiles under GCC-4.9.
Updates to ICU 60.2.
ICU made a new 60.2 release which already includes the GCC4.9 workaround from comment #10.
Attachment #8936475 - Attachment is obsolete: true
Updates ICU to release 60.2
Attachment #8937474 - Flags: review?(jwalden+bmo)
Attachment #8937474 - Flags: review?(jwalden+bmo) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/5241bdbfa0a5 Update in-tree ICU to release 60.2. rs=Waldo
You need to log in before you can comment on or make changes to this bug.