Closed Bug 1415878 Opened 2 years ago Closed 2 years ago

Accept both Chrome arrays and CSS colors for all properties

Categories

(WebExtensions :: General, enhancement, P5)

enhancement

Tracking

(firefox57 wontfix, firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- wontfix
firefox59 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

At the moment, only 2 properties support the Chrome form according to the schema: tab_text and frame. Those 2 also don't support the CSS color form.

The other properties only support the CSS color form.

It would be nice if we can allow both for all properties in the schema.
Blocks: themingapi-chrome
No longer blocks: themingapi
Severity: normal → enhancement
Priority: -- → P5
Comment on attachment 8928974 [details]
Bug 1415878 - Accept both Chrome arrays and CSS colors for all properties.

https://reviewboard.mozilla.org/r/200306/#review205542

Thank you for creating the ThemeColor type!
Attachment #8928974 - Flags: review?(jaws) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dcd749d0982c
Accept both Chrome arrays and CSS colors for all properties. r=jaws
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/dcd749d0982c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(ntim.bugs) → qe-verify-
ntim already updated the page for this, I just updated the compat data too: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme#Browser_compatibility

Marking dev-doc-complete, but please let me know if we need anything else.
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.