1415878 - Accept both Chrome arrays and CSS colors for all properties

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P5)

Description

[Tim Nguyen :ntim]

At the moment, only 2 properties support the Chrome form according to the schema: tab_text and frame. Those 2 also don't support the CSS color form.

The other properties only support the CSS color form.

It would be nice if we can allow both for all properties in the schema.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1415878 - Accept both Chrome arrays and CSS colors for all properties.

Review commit: https://reviewboard.mozilla.org/r/200306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200306/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8928974 [details]
Bug 1415878 - Accept both Chrome arrays and CSS colors for all properties.

https://reviewboard.mozilla.org/r/200306/#review205542

Thank you for creating the ThemeColor type!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcd749d0982c
Accept both Chrome arrays and CSS colors for all properties. r=jaws

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/dcd749d0982c

Comment 5

[Madalin Cotetiu]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 6

[Will Bamberg [:wbamberg]]

ntim already updated the page for this, I just updated the compat data too: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme#Browser_compatibility

Marking dev-doc-complete, but please let me know if we need anything else.