argument name 'reuse' in comment does not match parameter name 'addressReuse'

RESOLVED FIXED in Firefox 60

Status

()

P4
normal
Rank:
35
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sylvestre, Assigned: spencerb, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla60
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [good first bug][lang=C++])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Comment 1

a year ago
Assignee: nobody → spencerb
(Reporter)

Updated

a year ago
Attachment #8926887 - Attachment is obsolete: true
(Assignee)

Comment 3

a year ago
Thanks.  First attachment was an error due to my inexperience with mercurial.
(Assignee)

Updated

a year ago
Attachment #8926897 - Flags: review?(sledru)
(Reporter)

Comment 4

a year ago
Comment on attachment 8926897 [details] [diff] [review]
Change commented argument name to match declaration

Good, please try to find an official reviewer for this code!
Attachment #8926897 - Flags: review?(sledru) → feedback+
(Assignee)

Updated

a year ago
Attachment #8926897 - Flags: review?(drno)
Rank: 35
Priority: -- → P4
Comment on attachment 8926897 [details] [diff] [review]
Change commented argument name to match declaration

Review of attachment 8926897 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
And Thanks!
Attachment #8926897 - Flags: review?(drno) → review+

Comment 6

a year ago
Hey, is this issue still open?

Comment 8

a year ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09894bd08b93
Change commented argument name to match declaration r=drno
(Reporter)

Comment 9

a year ago
nope, sorry!

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/09894bd08b93
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
(Reporter)

Updated

a year ago
status-firefox58: affected → ---
You need to log in before you can comment on or make changes to this bug.