1415886 - argument name 'reuse' in comment does not match parameter name 'addressReuse'

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P4)

Description

[Sylvestre Ledru [:Sylvestre]]

https://dxr.mozilla.org/mozilla-central/source/media/mtransport/nr_socket_prsock.cpp?q=media%2Fmtransport%2Fnr_socket_prsock.cpp&redirect_type=direct#1580
uses "reuse"

When the method has addressReuse as variable name
https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/dist/include/nsIUDPSocketChild.h?q=%2Bfunction%3A%22nsIUDPSocketChild%3A%3ABind%28nsIUDPSocketInternal+%2A%2C+nsIPrincipal+%2A%2C+const+nsACString+%26%2C+uint16_t%2C+bool%2C+bool%2C+uint32_t%2C+uint32_t%2C+nsIEventTarget+%2A%29%22&redirect_type=single#61

A tiny issue but this will be a good first bug for someone who wants to understand the process.

Comment 1

[spencerb]

Attachment: Change commented argument name to match declaration

Comment 2

[spencerb]

Attachment: Change commented argument name to match declaration

Comment 3

[spencerb]

Thanks.  First attachment was an error due to my inexperience with mercurial.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8926897 [details] [diff] [review]
Change commented argument name to match declaration

Good, please try to find an official reviewer for this code!

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8926897 [details] [diff] [review]
Change commented argument name to match declaration

Review of attachment 8926897 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
And Thanks!

Comment 6

[Videet Singhai]

Hey, is this issue still open?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09894bd08b93467a61adab7e37c5920f775443f1
BUG 1415886 - Change commented argument name to match declaration r=drno

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09894bd08b93
Change commented argument name to match declaration r=drno

Comment 9

[Sylvestre Ledru [:Sylvestre]]

nope, sorry!

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/09894bd08b93