1415991 - remove support for verifying signed unpacked add-ons

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) [:keeler]]

See https://groups.google.com/d/msg/mozilla.dev.platform/cvv_mnXu7s0/N2DrXUxEBAAJ
Verifying signed unpacked add-ons is not something we need or want to support any longer. This simplifies the code for verifying signed packaged add-ons and will help us implement COSE signing.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: bug 1415991 - remove support for signed unpacked addons

Unfortunately we have a number of add-on installation tests that rely on
unpacked addons verifying as signed. The test infrastructure achieves this by
monkey-patching nsIX509CertDB.verifySignedDirectoryAsync to always succeed.
These tests are, in general, not actually testing the successful verification of
signed unpacked add-ons but rather other aspects of add-on installation,
updating, etc.. Some of these tests are certainly no longer relevant now that
legacy add-ons aren't supported, but we don't have the time to go through all of
them at the moment (this blocks updating add-on signature verification to use
COSE signatures, which we need to ship in 59 or we're probably not shipping at
all).

Review commit: https://reviewboard.mozilla.org/r/198298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198298/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8927082 [details]
bug 1415991 - remove support for signed unpacked addons

https://reviewboard.mozilla.org/r/198298/#review203546

Comment 3

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8927082 [details]
bug 1415991 - remove support for signed unpacked addons

https://reviewboard.mozilla.org/r/198298/#review204196

Comment 4

[Dana Keeler (she/her) [:keeler]]

Thanks for the reviews!
Here's try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=126f64eda07e
I'm not sure what the OS X bc-4 failure is, but it looks intermittent (I couldn't find a matching bug).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a5795108e0a
remove support for signed unpacked addons r=jcj,rhelmer

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0a5795108e0a

Comment 7

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 8

[Dana Keeler (she/her) [:keeler]]

I don't think this needs manual verification.

Comment 9

[Liz Henry (:lizzard)]

keeler, sounds like there is an alternate plan for doing this. Can you talk with ddurst? 
If you all decide to go with backout let me or jcristau know.

Comment 10

[Dana Keeler (she/her) [:keeler]]

This looks fairly straight-forward. I'm testing it out in https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbd7da7ccbbf2da230119ca776616547f0f2a89

Comment 11

[Liz Henry (:lizzard)]

OK. Can you file a new bug for the backout? It helps in tracking these issues for relman, sheriffs, etc.

Comment 12

[Dana Keeler (she/her) [:keeler]]

Filed bug 1439732.