Closed Bug 1415991 Opened 7 years ago Closed 7 years ago

remove support for verifying signed unpacked add-ons

Categories

(Core :: Security: PSM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

See https://groups.google.com/d/msg/mozilla.dev.platform/cvv_mnXu7s0/N2DrXUxEBAAJ
Verifying signed unpacked add-ons is not something we need or want to support any longer. This simplifies the code for verifying signed packaged add-ons and will help us implement COSE signing.
Comment on attachment 8927082 [details]
bug 1415991 - remove support for signed unpacked addons

https://reviewboard.mozilla.org/r/198298/#review203546
Attachment #8927082 - Flags: review?(rhelmer) → review+
Comment on attachment 8927082 [details]
bug 1415991 - remove support for signed unpacked addons

https://reviewboard.mozilla.org/r/198298/#review204196
Attachment #8927082 - Flags: review?(jjones) → review+
Thanks for the reviews!
Here's try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=126f64eda07e
I'm not sure what the OS X bc-4 failure is, but it looks intermittent (I couldn't find a matching bug).
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a5795108e0a
remove support for signed unpacked addons r=jcj,rhelmer
https://hg.mozilla.org/mozilla-central/rev/0a5795108e0a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(dkeeler)
I don't think this needs manual verification.
Flags: needinfo?(dkeeler) → qe-verify-
keeler, sounds like there is an alternate plan for doing this. Can you talk with ddurst? 
If you all decide to go with backout let me or jcristau know.
Flags: needinfo?(dkeeler)
This looks fairly straight-forward. I'm testing it out in https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbd7da7ccbbf2da230119ca776616547f0f2a89
Flags: needinfo?(dkeeler)
OK. Can you file a new bug for the backout? It helps in tracking these issues for relman, sheriffs, etc.
Depends on: 1460350
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: