Closed
Bug 1416185
Opened 7 years ago
Closed 7 years ago
js/src/jit/JitcodeMap.h:1371:18: error: private field 'count_' is not used [-Werror,-Wunused-private-field]
Categories
(Core :: JavaScript Engine: JIT, enhancement, P2)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: decoder, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.85 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
I got this error with Clang current trunk (r317840): https://treeherder.mozilla.org/logviewer.html#?job_id=143643775&repo=try&lineNumber=4913 jandem, can we fix this easily?
Flags: needinfo?(jdemooij)
|
Assignee | |
Comment 1•7 years ago
|
||
Sure, patch in a minute.
|
|
Assignee | |
Comment 2•7 years ago
|
||
We can just #ifdef DEBUG the count_ field.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Flags: needinfo?(jdemooij)
Attachment #8927272 -
Flags: review?(nicolas.b.pierron)
|
||
Updated•7 years ago
|
Blocks: clang-based-analysis
|
||
Updated•7 years ago
|
Priority: -- → P2
|
||
Updated•7 years ago
|
Attachment #8927272 -
Flags: review?(nicolas.b.pierron) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/815b8640da1e Fix Clang warning about unused private field in ScriptPcIterator. r=nbp
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/815b8640da1e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Comment 5•7 years ago
|
||
Won't fix for 58. Feel free to nominate if you disagree.
|
|
||
Updated•6 years ago
|
Blocks: build-clang-trunk
|
|
||
Updated•6 years ago
|
No longer blocks: clang-based-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•